Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inn: Harmony skips silence at the end of MIDIs #2611

Closed
2 tasks
fdelapena opened this issue Aug 14, 2021 · 3 comments · Fixed by #2678
Closed
2 tasks

Inn: Harmony skips silence at the end of MIDIs #2611

fdelapena opened this issue Aug 14, 2021 · 3 comments · Fixed by #2678

Comments

@fdelapena
Copy link
Contributor

fdelapena commented Aug 14, 2021

Name of the game: Any when triggering a call inn from event.

Player platform: Any

Attach files (as a .zip archive or link them)

POSADA.zip (from the game The Story Of Egroj).

Describe the issue in detail and how to reproduce it:

The attached MIDI file contains an inn jingle with notes for around 4 seconds, but the total MIDI length is around 28 seconds because it contains a marker as a comment after around 28 seconds. It does not contain event loop (111).

marker

Harmony respects the silence on maps, but skips the silence on Inn.

Player does not skip silence for libfluidsynth and native MIDI on Inn.

Note: if the MIDI loops and the sequence does not end, it is a different issue, fixed since #2612.

  • Check if Harmony sends some kind of event to the MIDI device. cc @tyrone-sudeium
  • Test behavior with MIDIs with 111 event loop.

Related: #2584

@Ghabry
Copy link
Member

Ghabry commented Aug 23, 2021

Does it fade in(n) directly after the 4 seconds?

What I can see is that there seems to be a time-out for how long the Inn BGM can play. Should be 10 or 20 seconds.

@Ghabry
Copy link
Member

Ghabry commented Aug 24, 2021

Imo your example here is the 10 second timeout. I get approx this amount of wait time.

You can also:
Unfocus the window when the Inn music starts. When it is almost done do a refocus. There will be around ~9 seconds of silence.

@ghost
Copy link

ghost commented Oct 3, 2021

In RPG_RT if the inn BGM has a length of 10 seconds or more, the inn BGM always timeouts after 10 seconds.

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Nov 1, 2021
@Ghabry Ghabry added this to the 0.7.1 milestone Nov 1, 2021
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants