Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yume2kki: Map not passable when going from Christmas World to Exhibition #2716

Closed
Ghabry opened this issue Jan 14, 2022 · 3 comments · Fixed by #2717
Closed

Yume2kki: Map not passable when going from Christmas World to Exhibition #2716

Ghabry opened this issue Jan 14, 2022 · 3 comments · Fixed by #2717
Labels
Event/Interpreter Hang Maps Map content related. For map events please use event/interpreter instead Patch available
Milestone

Comments

@Ghabry
Copy link
Member

Ghabry commented Jan 14, 2022

Name of the game: Yume2kki

Attach files (as a .zip archive or link them)

a.mp4

Describe the issue in detail and how to reproduce it:

Go from MAP0318 (Exhibition) to MAP0341 (Christmas World, main area).

Movement is not possible.

The tilemap uses the last tile of the tilemap. Maybe that is the reason?

Interestingly it works when you e.g. Debug move to Exhibition. Then the map is passable o_O

@Ghabry Ghabry added Event/Interpreter Hang Maps Map content related. For map events please use event/interpreter instead labels Jan 14, 2022
@Ghabry Ghabry added this to the 0.7.1 milestone Jan 14, 2022
@Ghabry
Copy link
Member Author

Ghabry commented Jan 14, 2022

Uhm, yeeeah.

So the teleport is out of bounds: The Y-Value is too high by one. So the resulting Y is not inside the map. This results in the function that checks whether you can leave the current to not work.

Though because it is a looping map the value is wrapped and should result in a 0 instead of a 66.

@Ghabry
Copy link
Member Author

Ghabry commented Jan 14, 2022

When looking at a save the Y-value remains untouched until you move up or down. Then it is set properly inbounds again.

So this should be handled for proper compatibility here.

@Ghabry
Copy link
Member Author

Ghabry commented Jan 14, 2022

Imo this is a RPG_RT bug. This also has odd behaviours like you cannot trigger events while you are on these out-of-bounds coordinates. So when Y is OOB and you walk left/right on-touch triggers do not launch. Great.

Though Terrain Tags loop so you cannot walk through stuff.

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jan 14, 2022
Fixes a stuck Player in Yume2kki when teleporting from Christmas World to Exhibition.
The teleport target is out-of-bounds (maybe because the map was resized later) preventing leaving the tile.

This is not fully bug compatible to RPG_RT. Assuming the Y-Coordinate is out-of-bounds: When moving
left or right the invalid Y will stay in RPG_RT preventing events from being triggered, but we wrap it
inbounds after the first move.

Fix EasyRPG#2716
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jan 14, 2022
Fixes a stuck Player in Yume2kki when teleporting from Christmas World to Exhibition.
The teleport target is out-of-bounds (maybe because the map was resized later) preventing leaving the tile.

This is not fully bug compatible to RPG_RT. Assuming the Y-Coordinate is out-of-bounds: When moving
left or right the invalid Y will stay in RPG_RT preventing events from being triggered, but we wrap it
inbounds after the first move.

Fix EasyRPG#2716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event/Interpreter Hang Maps Map content related. For map events please use event/interpreter instead Patch available
Development

Successfully merging a pull request may close this issue.

1 participant