Skip to content

CJK Encoding error in webplayer's title. #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lychees opened this issue Feb 17, 2022 · 4 comments
Closed

CJK Encoding error in webplayer's title. #2727

lychees opened this issue Feb 17, 2022 · 4 comments
Labels
Emscripten WebAssembly/JavaScript port for web browsers Patch available
Milestone
0.8.0

Comments

@lychees
Copy link
Contributor

lychees commented Feb 17, 2022 •
edited
Loading

Player platform:

Web

Describe the issue in detail and how to reproduce it:

image
We only find this bug in web broswer, seems ok in native version. I guess we could resolve this issue by convert from GBK to UTF8 before execute the SDL_SetWindowTitle() function.
@lychees lychees changed the title Title Encoding error in webplayer. CJK Encoding error in webplayer's title. Feb 17, 2022
@Ghabry
Copy link
Member

Ghabry commented Feb 17, 2022

The title is converted. Imo that is a SDL2 bug

@fdelapena fdelapena added the Emscripten WebAssembly/JavaScript port for web browsers label Feb 17, 2022
@Ghabry
Copy link
Member

Ghabry commented Feb 17, 2022

emscripten-core/emscripten#16327

@lychees
Copy link
Contributor Author

lychees commented Feb 18, 2022

Yes, you are right, I try to convert it but the result is same.
I think you already found their fault. ;) Waiting for their merged and next release.

@Ghabry Ghabry added this to the 0.7.1 milestone Mar 14, 2022
@Ghabry
Copy link
Member

Ghabry commented Mar 14, 2022

Buildscripts were updated and everything rebuilt.
Works now: https://easyrpg.org/play/master/?game=yume_nikki

@Ghabry Ghabry closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Emscripten WebAssembly/JavaScript port for web browsers Patch available
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@fdelapena @Ghabry @lychees