Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data loss when saving in translated games #2887

Closed
Ghabry opened this issue Jan 30, 2023 · 0 comments · Fixed by #2921
Closed

Data loss when saving in translated games #2887

Ghabry opened this issue Jan 30, 2023 · 0 comments · Fixed by #2921

Comments

@Ghabry
Copy link
Member

Ghabry commented Jan 30, 2023

Even for games that use the translation feature savegames still use the local encoding of the game.

Assuming the original game is "Western European" and the translation is "Japanese"

When saving the savegame can contain Japanese game from active events or e.g. a translated hero name.

All the Japanese data in that savegame is lost when converted to "Western European".


Maybe add a new chunk unicode to the easyrpg section of the savegame. When set the savegame is saved as UTF-8 and loaded as UTF-8 encoding preventing data loss 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants