Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition Show: Inwards is not correctly displayed and transition Show: Fade in is too fast compared to the RPG_RT #2901

Closed
2 tasks done
Mimigris opened this issue Feb 26, 2023 · 5 comments
Milestone

Comments

@Mimigris
Copy link

Mimigris commented Feb 26, 2023

Name of the game:

EasyRPG Test Game 2000.

Player platform:

Windows, latest continuous build of EasyRPG Player.

Describe the issue in detail and how to reproduce it:

  • When transition Show: Inwards is called, no transition will seems to appear due to not being implemented. Actually it seems to be coded but it is not displayed correctly.
    Should be fixed with Various fixes #2913

  • The transition Show: Fade in on the other side is a bit too fast on EasyRPG Player, and should be around the speed than the Hide: Fade out transition instead of being faster than it, like on the RPG_RT. Various fixes #2913

@Mimigris Mimigris changed the title Transition Show: Inwards is not supported and transition Show: Fade in is too fast compared to the RPG_RT Transition Show: Inwards is not correctly displayed and transition Show: Fade in is too fast compared to the RPG_RT Mar 14, 2023
@Mimigris
Copy link
Author

Small update about Show: Inwards as previously mentioned a few days ago: the transition seems to be implemented, but is not correctly displayed. The transition can actually be seen in some specific occasions currently:

On Windows and on the web Player (I've not tested further than that in terms of platforms), it can partially be seen if a warning message is displayed on-screen (this is the square displayed under the warning messages):
screenshot_5

And on 3DS, it seems to be displayed normally:
3DS_erpg_show_inwards

@Ghabry
Copy link
Member

Ghabry commented Mar 14, 2023

Thanks for tracking this down. This is obviously a problem with the alpha value of the framebuffer image (the alpha value is never used for anything because there is nothing "behind" the framebuffer but here pixman considers the copied framebufer as fully transparent)

Easy to fix :)

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Mar 14, 2023
@Ghabry Ghabry added this to the 0.8.0 milestone Mar 14, 2023
@Ghabry Ghabry modified the milestones: 0.8.0, 0.8.1 Mar 15, 2023
@Ghabry
Copy link
Member

Ghabry commented Mar 15, 2023

oh, this one is only half-fixed by my PR but is marked as auto-close. Will manually reopen the issue after the PR is merged

@Ghabry
Copy link
Member

Ghabry commented Mar 15, 2023

reopening because 2nd half is not fixed

@Ghabry Ghabry reopened this Mar 15, 2023
@Mimigris
Copy link
Author

It seems that the speed of the Show: Fade in transition was also fixed with the PR #2913, so this issue should be completely resolved now.

@Ghabry Ghabry modified the milestones: 0.8.1, 0.8.0 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants