Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yume 2kki - Playing an almost empty wav file breaks the audio of the Player #2950

Closed
Mimigris opened this issue Apr 7, 2023 · 1 comment
Closed

Comments

@Mimigris
Copy link

Mimigris commented Apr 7, 2023

Name of the game:

Yume 2kki version 0.120, patch 8 and more.

Player platform:

Windows, version 0.7.0 and latest continuous build of the Player.

Attach files (as a .zip archive or link them)

Music file related to the issue: x[]_musi#00.zip

Describe the issue in detail and how to reproduce it:

When playing this wav file as a Music in the Player, the audio of the Player will be broken and will just indefinitely play the sound effects played while this Music lasts (see video here - note that it will download the video on your side). Important to note about this file is that it lasts 0.0 second and is 44 bytes with almost nothing in it, so it's likely related to that.

@Ghabry
Copy link
Member

Ghabry commented Apr 12, 2023

Actually we already have code for this (we try to fill the audio buffer 10 times and if it fails the stream is tagged as faulty and discarded). The error check was just incorrect xD

@Ghabry Ghabry added this to the 0.8.0 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants