EasyRPG Player freezes after sleeping on Nintendo Switch

[MataKrow]

Name of the game: EasyRPG Player continuous build

Player platform: Nintendo Switch

Describe the issue in detail and how to reproduce it: Enter sleep mode with EasyRPG Player

[jwikiera]

Opening the home menu freezes it as well

[univeous]

This issue is not present in version 0.7. I think this is a regression

[Ghabry]

Can you give further detail what "freeze" means? Does the entire system crash or is easyrpg hanging? Maybe a short video would be good

[univeous]

After pausing or returning to the main menu and re-entering, EasyRPG hangs, not accepting any inputs, the screen freezes, and the sound does not play; it cannot be forced to close from the main menu, and will only attempt to close for a long time then the error: The software was closed because an error occurred.
This also occurs in the latest (2024-09-13) continuous build.

[carstene1ns]

The error on closing is expected in this case, since we lock the applet exit. So HOS waits for us and finally decides we must be closed forcefully.

[carstene1ns]

Okay, after investigating this is some kind of race condition.
The applet focus state is not updated correctly and so player waits indefinitely in ProcessEvents().
It takes one iteration of our main loop to catch the new state.

diff --git a/src/platform/switch/ui.cpp b/src/platform/switch/ui.cpp
index 957dba60d..834080d5c 100644
--- a/src/platform/switch/ui.cpp
+++ b/src/platform/switch/ui.cpp
@@ -392,12 +392,12 @@ NxUi::~NxUi() {

 bool NxUi::ProcessEvents() {
        // handle system events
-       appletMainLoop();
+       if (!appletMainLoop())
+               return false;

-       // idle, when out of focus
-       while(appletGetFocusState() != AppletFocusState_InFocus) {
-               Game_Clock::SleepFor(10ms);
-       }
+       // skip, when out of focus
+       if(appletGetFocusState() != AppletFocusState_InFocus)
+               return true;

        padUpdate(&pad);

@@ -458,6 +458,10 @@ bool NxUi::ProcessEvents() {
 }

 void NxUi::UpdateDisplay() {
+       // skip, when out of focus
+       if(appletGetFocusState() != AppletFocusState_InFocus)
+               return;
+
        float aspectX = 1.0f;
        float aspectY = 1.0f;

[Ghabry]

Another possible issue: AppletHookType_OnExitRequest calls Player::Exit which deletes the DisplayUi. Guess the event is processed when appletMainLoop is called? So it would return into code of a deleted object.