Skip to content

Maniac: Key input processing - The key that should be detected for Mouse Scroll Up key is binded to Mouse Scroll Down #3072

Description

@Mimigris

Player platform:

Windows, 64 bits continuous build of the Player.

Describe the issue in detail and how to reproduce it:

When using the extended Key Input Processing command from the Maniac Patch (not Key Input EX), and specifying to track the Mouse Scroll Up key (value 1004), using the actual Scroll Up key will not set the value to 1004 as intended. Instead, the value will be set to 1004 by pressing the Scroll Down key, which will cause issues if both keys are tracked with a single command since 1) Scroll Up will have no purpose and 2) the value returned will only be able to be 1001 since the actual Scroll Down key will have priority over the Scroll Up key.

The issue is in src/game_interpreter.cpp: around line 3091 (may change if pull requests are applied), the following line is present
if (keys[Keys::eMouseScrollUp] && check(Input::SCROLL_DOWN)) {
while it should normally be
if (keys[Keys::eMouseScrollUp] && check(Input::SCROLL_UP)) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    InputInput related (gamepads, keyboard mappings, mouse support). For KeyInputProc, add event/interpreterPatch availableRPG_RT Patches

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions