Skip to content

/ Player

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Battle commands with 'Enemy HP' trigger crash the game #367

Closed
rohkea opened this issue Nov 24, 2014 · 2 comments
Closed

Battle commands with 'Enemy HP' trigger crash the game #367

rohkea opened this issue Nov 24, 2014 · 2 comments
Labels
Battle Crash Event/Interpreter Patch available Testcase available
Milestone
0.3

Comments

@rohkea
Copy link
Member

@rohkea rohkea commented Nov 24, 2014

Having a battle commands triggered with 'Enemy HP is ...' causes the player to exit immediately, with the following error message:

easyrpg-player: game_enemyparty.cpp:30: virtual Game_Enemy& Game_EnemyParty::operator: Assertion `false && "Subscript out of range"' failed.

Here is a minimal test project: http://ablog.site90.com/fun/BattleFailExample.zip

This affects Legion Saga (the fight with Mr Yuto).
@rohkea rohkea changed the title Battle commands with 'Enemy HP' crash the game Battle commands with 'Enemy HP' trigger crash the game Nov 24, 2014
@Zegeri
Copy link
Member

@Zegeri Zegeri commented Nov 30, 2014

4a40dfb should fix this.
@rohkea
Copy link
Member Author

@rohkea rohkea commented Nov 30, 2014

Thanks, this patch works!

The battle with Mr Yuto in Legion Saga still has problems because 'Stop Battle' command is missing, but at least it’s no longer crashing.
@Zegeri Zegeri mentioned this issue Dec 28, 2014
Merged
@fdelapena fdelapena added this to the 0.3 milestone Jan 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Battle Crash Event/Interpreter Patch available Testcase available
Projects
None yet
Milestone
0.3
Linked pull requests

Successfully merging a pull request may close this issue.

Fix some bugs
3 participants
@fdelapena @rohkea @Zegeri