Ahriman's prophecy doesn't recognize ESC button #433

Closed
ghost opened this Issue Mar 9, 2015 · 15 comments

Projects

None yet

5 participants

@ghost
ghost commented Mar 9, 2015

No description provided.

@ghost
ghost commented Mar 9, 2015

Download the game here:
http://aveyond.com/games/ahrimans-prophecy/
I don't think there's problems since is freeware.

@fdelapena fdelapena added this to the 0.3 milestone Mar 10, 2015
@Zegeri
Member
Zegeri commented Mar 10, 2015

The problem is in the Common Event 48 "Call CMS". It's a parallel process triggered by the switch 0453 "Call CMS". When the player press ESC the following lines are executed:

  Switch Operation [0453:Call CMS] OFF
  Switch Operation [0988:Call CBM] ON
  Call Event: Call CBM
  Break Loop

After 0453 is switched off, easyrpg-player stops the processing of this common event and everything after it isn't executed. In RPG_RT.exe, every line is executed.

@Ghabry
Member
Ghabry commented Mar 10, 2015

The instant termination of Parallel Processes is by design because RPG_RT does this. At least for map events, maybe it's different for Parallel Common events? -.-

@scurest
Contributor
scurest commented Mar 12, 2015

Seems to be like Ghabry says. But wait, it gets weirder.

Make an event E that flips Switch 1 on when you trigger it, a common parallel event conditional on Switch 1 with the commands

flip Switch 1 off
add 1 to Variable 1
wait 0.1 seconds
add 1 to Variable 1

and an event to check the value of Variable 1.

After triggering E 0,1,2,3,4,... times, the respective values of Var 1 afterwards are 0,1,3,5,7,... !

@Zegeri
Member
Zegeri commented Mar 12, 2015

That's correct, the common event won't stop even after switching its trigger off until the wait command. But when you activate its trigger again, it won't start from the beginning, but from its last position, i.e. the wait command. That's why it'll run the two variable operations the second time you run it.

@Zegeri
Member
Zegeri commented Mar 24, 2015

This issue and the whole common event stuff should be fixed in my development branch. Now let's make sure there are no regressions.

@Zegeri Zegeri was assigned by fdelapena Mar 25, 2015
@fdelapena
Member

Tested with a couple of games with unrelated issues (Warrior Saga, Desolate City, Clock of Atonement), all of them are working as usual (with their own bugs). I haven't detected regressions with your branch so far.
In Wadanohara there was a bug with a mirror, the picture form the mirror doesn't keep opened more than a few hundred milliseconds when pressing the decision key. I have no idea if related and not tested yet with your branch.

Maybe this game is worth to test due to its complexity (action RPG, menus...):
http://www.pyxosoft.com/downloads/zelda_links_awakening_100.zip

@Ghabry
Member
Ghabry commented Mar 26, 2015

Links awakening actually has a strange bug at the beginning. The princess moves very slow and is off by one tile until she is close to link. In RPG_RT shes speednig up.
Not sure if this got already fixed by accident.

@fdelapena fdelapena modified the milestone: 0.3.1, 0.3 Apr 29, 2015
@Ghabry
Member
Ghabry commented May 15, 2015

Was that fixed by @Zegeri latests KeyInput changes?

@fdelapena
Member

Esc button does not work in upstream master yet. Development branch changes are not merged.

@Zegeri
Member
Zegeri commented May 16, 2015

This is fixed in my interpreter branch, but it breaks other things.

@fdelapena
Member

Online version for testing. Note sometimes fails the 1 key for some reason, and seems to work fine on Desktop:

For latest pull request:
https://easy-rpg.org/play/index-pr.html?game=ahrimans_prophecy
For upstream master:
https://easy-rpg.org/play/?game=ahrimans_prophecy

@fdelapena fdelapena removed the Emulation label May 19, 2015
@fdelapena fdelapena closed this in #526 Jul 27, 2015
@fdelapena
Member

It looks like this issue regressed. Esc/X is not opening the menu anymore.

@fdelapena fdelapena reopened this Oct 5, 2015
@Zegeri
Member
Zegeri commented Oct 5, 2015

My mistake. The changes in src/game_interpreter.cpp in 30a3b58 shouldn't be there. The main_flag check must be there (see #578).

@fdelapena fdelapena modified the milestone: 0.4, 0.3.1 Oct 5, 2015
@carstene1ns
Member

I can confirm adding the main_flag check back in makes the menu work again.
This also affects TSTT, btw. You currently also cannot use the ESC menu.

@Ghabry Ghabry closed this in #640 Oct 22, 2015
@carstene1ns carstene1ns added Events and removed Events Interpreter labels Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment