New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen shake not implemented #565

Closed
Ghabry opened this Issue Sep 5, 2015 · 5 comments

Comments

Projects
None yet
5 participants
@Ghabry
Member

Ghabry commented Sep 5, 2015

That one seems tricky

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Sep 5, 2015

Member

With RPG_RT.exe, screen shakes is just the translation of the screen. If the screen shake to the left, there is a black rectangle at the right area : the screen is just transfered to the left and the right area of the map is not rendered. I don't like that comportment but it might be easier to implement.

Member

BlisterB commented Sep 5, 2015

With RPG_RT.exe, screen shakes is just the translation of the screen. If the screen shake to the left, there is a black rectangle at the right area : the screen is just transfered to the left and the right area of the map is not rendered. I don't like that comportment but it might be easier to implement.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Sep 5, 2015

Member

In RPG_RT the map is rendered, except if the shake overlaps the map boundary

Member

Ghabry commented Sep 5, 2015

In RPG_RT the map is rendered, except if the shake overlaps the map boundary

@scurest

This comment has been minimized.

Show comment
Hide comment
@scurest

scurest Sep 5, 2015

Contributor

For the map screen, just adding Main_Data::game_data.screen.shake_position to Game_Map::GetDisplayX seems to work (the only problem I noticed was that if the map loops horizontally and has never scrolled horizontally before, there will black border as though it didn't loop. Once moving right or left, it seemed to work correctly.)

edit: Here's the exact patch I used.

Contributor

scurest commented Sep 5, 2015

For the map screen, just adding Main_Data::game_data.screen.shake_position to Game_Map::GetDisplayX seems to work (the only problem I noticed was that if the map loops horizontally and has never scrolled horizontally before, there will black border as though it didn't loop. Once moving right or left, it seemed to work correctly.)

edit: Here's the exact patch I used.

scurest added a commit to scurest/Player that referenced this issue Sep 6, 2015

@Ghabry Ghabry added this to the 0.4 milestone Sep 13, 2015

@fdelapena

This comment has been minimized.

Show comment
Hide comment
@fdelapena

fdelapena Sep 21, 2015

Contributor

Talk with the slime in this test case to reproduce it.

Contributor

fdelapena commented Sep 21, 2015

Talk with the slime in this test case to reproduce it.

@Ghabry Ghabry modified the milestones: 0.4.1, 0.4 Dec 17, 2015

@Ghabry Ghabry modified the milestones: 0.4.1, 0.5.0 Feb 19, 2016

@Ghabry Ghabry modified the milestones: 0.6.0, 0.5.1 Sep 9, 2016

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 4, 2017

Member

For a map everything below the messagebox shakes.
For battle everything below the UI shakes.

Member

Ghabry commented Feb 4, 2017

For a map everything below the messagebox shakes.
For battle everything below the UI shakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment