Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel common events and parallel map events synchronization issues #662

Closed
trotterdotp opened this issue Dec 6, 2015 · 6 comments

Comments

@trotterdotp
Copy link

commented Dec 6, 2015

easyRPGdebugparall.zip
In this sample game, there is a parallel common event displaying the text "1" and a parallel map event displaying "2".

Using RPG_RT.exe 1.8.0 / 1.9.1 / 1.1.0, you should read:
---- > "1, 2"
then
---- > "1, 1, 2, 1, 1, 2, 1, 1, 2, 1, 1, 2....."

Using player.exe:
---- > sometime it starts with 1, sometime it starts with 2. That's the first problem.
then
---- > "1, 2, 1, 2, 1, 2, 1, 2, 1, 2, 1, 2.....". That's the second problem.

Parallel common event should maybe be prioritized?

Again many thanks for your work.

@Ghabry Ghabry added the Interpreter label Dec 6, 2015

@Ghabry

This comment has been minimized.

Copy link
Member

commented Dec 6, 2015

That's one of this tricky timing bugs in the interpreter.
We are currently trying to compare Player with RPG_RT directly by logging event execution using DynRPG an then comparing it.
See #646. This is a good candidate for a test, thanks.

This one won't be fixed as fast as your first one ;)

@Zegeri

This comment has been minimized.

Copy link
Member

commented Feb 7, 2016

Parallel common events are now executed first, so it should now always start with "1".
The pattern "1,2,1,1,2,1..." is caused by the way RPG_RT deals with messages. 83d0f56 used to replicate this behaviour.

Just a curiosity. Have n parallel events displaying the numbers 1,2...n. If you've ever played around with Towers of Hanoi, you'll see that the pattern you get resembles the iterative solution of the Tower of Hanoi of n disks.

@fdelapena fdelapena added this to the 0.4.1 milestone Feb 8, 2016

@Ghabry Ghabry closed this Feb 8, 2016

@Zegeri

This comment has been minimized.

Copy link
Member

commented Feb 9, 2016

I didn't include a patch for this in #753. Please, reopen this.

@Ghabry Ghabry reopened this Feb 9, 2016

@Ghabry

This comment has been minimized.

Copy link
Member

commented Feb 9, 2016

Sorry, I interpreted the comment above incorrectly

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2019

I just tried this master and it looks to be fixed.

I get 1,2,1,1,2,1,1,2,1,1,2,...

@Ghabry

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Tested it with 4 message boxes: Works.

But for this one I'm actually curious why the result is matching the hanoi-solution as noticed by Zegeri. Adding this to my "stuff for long nights"-list. xD

@Ghabry Ghabry closed this Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.