F12 / end game should stop music and channels playback #756

Closed
fdelapena opened this Issue Feb 8, 2016 · 1 comment

Projects

None yet

3 participants

@fdelapena
Member

This is easy to reproduce when a game does not use music in the title scene, it will keep existing music and channels playing. In RPG_RT it will "play" silence.
This shouldn't be handled from the title scene because 2k3 1.11 can skip it, this should be handled in the end game.
Test with a 2k3 1.11 game skipping title scene and returning to a map without music: https://easy-rpg.org/play/?game=itwr

@Ghabry Ghabry modified the milestone: 0.5.0 Feb 19, 2016
@carstene1ns
Member

The music issue only applies to games which skip the title scene.
If the title scene is enabled, it will stop the music if it is empty. (Long) sound effects continue to play.

Stopping the audio playback could be done where the reset_flag gets cleared here to not touch the title scene, but as it will be used nonetheless, doing it there makes more sense.

@fdelapena fdelapena closed this in a4ca41d Mar 4, 2016
@Ghabry Ghabry modified the milestone: 0.4.1, 0.5.0 Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment