Automatic scrolling background images sometimes jump #761

Closed
carstene1ns opened this Issue Feb 9, 2016 · 9 comments

Comments

Projects
None yet
4 participants
@carstene1ns
Member

carstene1ns commented Feb 9, 2016

Did not test this with RPG_RT, but it seems like a glitch:
bg_jump

Related: #314 and #455.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 9, 2016

Member

Yepp they jump at the map boundaries when the map is looping.

Member

Ghabry commented Feb 9, 2016

Yepp they jump at the map boundaries when the map is looping.

@fdelapena

This comment has been minimized.

Show comment
Hide comment
@fdelapena

fdelapena Feb 18, 2016

Contributor

Note: it does not jump in map boundaries if the panorama has automatic scroll, then the jump position will vary.

Contributor

fdelapena commented Feb 18, 2016

Note: it does not jump in map boundaries if the panorama has automatic scroll, then the jump position will vary.

@Ghabry Ghabry modified the milestone: 0.5.0 Feb 19, 2016

carstene1ns added a commit to carstene1ns/easyrpg-player that referenced this issue Jul 30, 2016

Fix #761, Reset paralax background position
when crossing a looping map border.

@carstene1ns carstene1ns removed this from the 0.6.0 milestone Jul 31, 2016

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jul 31, 2016

Member

Wow, I do not know what I am trying to achieve here, but this seems already been fixed by an unrelated commit before 0.4.0.

Member

carstene1ns commented Jul 31, 2016

Wow, I do not know what I am trying to achieve here, but this seems already been fixed by an unrelated commit before 0.4.0.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Oct 4, 2016

Member

At least in .flow and Yume Nikki it can not be observed anymore.
However, in Standstill Girl in Shadeling Town (start map, just go to the hospital) it still happens. Reopening.

Member

carstene1ns commented Oct 4, 2016

At least in .flow and Yume Nikki it can not be observed anymore.
However, in Standstill Girl in Shadeling Town (start map, just go to the hospital) it still happens. Reopening.

@carstene1ns carstene1ns reopened this Oct 4, 2016

@carstene1ns carstene1ns added this to the 0.5.1 milestone Oct 4, 2016

@carstene1ns carstene1ns changed the title from Looping map panoramas jump to Automatic scrolling background images sometimes jump Oct 4, 2016

@scurest

This comment has been minimized.

Show comment
Hide comment
@scurest

scurest Feb 17, 2017

Contributor

I think this is this typo

diff --git a/src/bitmap.cpp b/src/bitmap.cpp
index e54fb610..307f4b35 100644
--- a/src/bitmap.cpp
+++ b/src/bitmap.cpp
@@ -676,3 +676,3 @@ void Bitmap::TiledBlit(int ox, int oy, Rect const& src_rect, Bitmap const& src,
 	if (ox >= src_rect.width)	ox %= src_rect.width;
-	if (oy >= src_rect.height)	ox %= src_rect.height;
+	if (oy >= src_rect.height)	oy %= src_rect.height;
 	if (ox < 0) ox += src_rect.width  * ((-ox + src_rect.width  - 1) / src_rect.width);
Contributor

scurest commented Feb 17, 2017

I think this is this typo

diff --git a/src/bitmap.cpp b/src/bitmap.cpp
index e54fb610..307f4b35 100644
--- a/src/bitmap.cpp
+++ b/src/bitmap.cpp
@@ -676,3 +676,3 @@ void Bitmap::TiledBlit(int ox, int oy, Rect const& src_rect, Bitmap const& src,
 	if (ox >= src_rect.width)	ox %= src_rect.width;
-	if (oy >= src_rect.height)	ox %= src_rect.height;
+	if (oy >= src_rect.height)	oy %= src_rect.height;
 	if (ox < 0) ox += src_rect.width  * ((-ox + src_rect.width  - 1) / src_rect.width);
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 17, 2017

Member

looks like a candidate, obviously wrong 👍

Member

Ghabry commented Feb 17, 2017

looks like a candidate, obviously wrong 👍

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Feb 17, 2017

Member

Good find, will test later today, if this fixes the issue in Standstill Girl. Going by the commit info, this bug has been present since 2012 at least... 😲

Member

carstene1ns commented Feb 17, 2017

Good find, will test later today, if this fixes the issue in Standstill Girl. Going by the commit info, this bug has been present since 2012 at least... 😲

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 17, 2017

Member

yeah this bug exists since looping maps were implemented because Yume Nikki needed them to be playable. :D

Member

Ghabry commented Feb 17, 2017

yeah this bug exists since looping maps were implemented because Yume Nikki needed them to be playable. :D

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Feb 18, 2017

Member

confirmed fixed.

Member

carstene1ns commented Feb 18, 2017

confirmed fixed.

@Ghabry Ghabry closed this in 610aaee Feb 19, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this issue May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment