Calling a common event from battle uses the battle interpreter and breaks most common events #788

Closed
Ghabry opened this Issue Mar 1, 2016 · 1 comment

Projects

None yet

2 participants

@Ghabry
Member
Ghabry commented Mar 1, 2016

TestCase:
Battle 198 in AraFell.

Displays "Seri Kesu casts powerful spells, but her Magic
does not regenerate during combat unless she
defends. Her Magic is restored after battles." but shouldn't.

Reason is using a ConditionalBranch. This is only implemented for the Map interpreter, not for Battle interpreter. Maybe we should move almost all commands to Game_Interpreter (except the ones that really don't make sense to use in battle).

@Ghabry Ghabry added this to the 0.5.0 milestone Mar 1, 2016
@Ghabry Ghabry changed the title from Calling a common event from battle using the battle interpreter and breaks most common events to Calling a common event from battle uses the battle interpreter and breaks most common events Mar 1, 2016
@Ghabry Ghabry referenced this issue Apr 3, 2016
Merged

Fix battle bugs #852

@Ghabry Ghabry self-assigned this Apr 8, 2016
@Ghabry Ghabry modified the milestone: 0.5.0, 0.4.2 Apr 11, 2016
@fdelapena fdelapena pushed a commit that closed this issue May 29, 2016
@Ghabry Ghabry Move most map interpreter code to interpreter because the battle inte…
…rpreter also needs these commands. Fix #788
ba9d8d3
@fdelapena fdelapena closed this in ba9d8d3 May 29, 2016
@carstene1ns carstene1ns added Events and removed Events Interpreter labels Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment