Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embric of Wulfhammer's Castle: Sound effect repeating incorrectly [MIDI loop point] #834

Closed
Siltala opened this issue Mar 19, 2016 · 6 comments · Fixed by #2250
Closed

Comments

@Siltala
Copy link

Siltala commented Mar 19, 2016

This game has a scene in which the Duchess goes to sleep. It is accompanied by a short sound effect, which in RPG_RT plays only once. In EasyRPG, however, the sound effect incorrectly constantly repeats itself.

To reproduce, load the save game and talk to Alice (immediately in front of the Duchess in the savegame)

Edit: added MIDI loop test case and online test in Emscripten (with FMMIDI).


See #2199

@carstene1ns
Copy link
Member

carstene1ns commented Mar 20, 2016

At a first glance, we do it right here. The music is set to item.mid and nowhere stopped.
For the devs: Map0082, EV0011 (Alice):
event


Edit: However, this midi has a loop point at the end of the file and so RPG_RT seems to play silence.
Midi info:

    Start:  2.181816 seconds
    End:    5.517040 seconds
    Length: 3.335224 seconds

    LOOPSTART:  6.517040 seconds
    LOOPLENGTH: 0.000000 seconds

@Ghabry Ghabry added the Audio label Mar 20, 2016
@fdelapena
Copy link
Contributor

Okay, this midi has a loop point at the end of the file and so RPG_RT seems to play silence.

Is the midi loop set with a "111" MIDI event controller change?

Event details:

The event time corresponds to the loop start place when the song ends.
0xB0 This is the event numeric ID (176 in decimal) meaning channel 1 Control mode change (aka controller change)
0x6F (111 in decimal), Undefined in standard control table (RPG Maker 2000/2003/XP specific)
0x00 The third event byte looks unused for this controller.

RTP's Battle3.mid example: 98 00 (delta time PPQ, place to restart) B0 6F 00 (controller 111)

@carstene1ns
Copy link
Member

Yep.

@carstene1ns carstene1ns changed the title Embric of Wulfhammer's Castle: Sound effect repeating incorrectly Embric of Wulfhammer's Castle: Sound effect repeating incorrectly [MIDI loop point] Oct 2, 2016
@carstene1ns carstene1ns added this to the 0.6.0 milestone Apr 17, 2017
@fdelapena
Copy link
Contributor

Added an isolated test case and emscripten link in the OP post.

@Ghabry Ghabry modified the milestones: 0.6.1, 0.7.0 May 5, 2019
@fdelapena fdelapena added the MIDI label Jan 13, 2020
@Ghabry Ghabry modified the milestones: 0.7.0, 0.6.3 Jun 17, 2020
@Ghabry
Copy link
Member

Ghabry commented Jun 17, 2020

Moving to 0.6.3 because of massive Midi work right now :).

This is partially fixed now (FmMidi only).

@Ghabry Ghabry mentioned this issue Jun 17, 2020
1 task
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jun 17, 2020
The AudioDecoder will destroy it because it is stuck at "IsFinished" but the BGM must be kept alive to match RPG_RT.

Fix EasyRPG#834
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jun 18, 2020
The AudioDecoder will destroy it because it is stuck at "IsFinished" but the BGM must be kept alive to match RPG_RT.

Fix EasyRPG#834
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Aug 16, 2020
The AudioDecoder will destroy it because it is stuck at "IsFinished" but the BGM must be kept alive to match RPG_RT.

Fix EasyRPG#834
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Aug 18, 2020
The AudioDecoder will destroy it because it is stuck at "IsFinished" but the BGM must be kept alive to match RPG_RT.

Fix EasyRPG#834
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Aug 22, 2020
The AudioDecoder will destroy it because it is stuck at "IsFinished" but the BGM must be kept alive to match RPG_RT.

Fix EasyRPG#834
@Ghabry
Copy link
Member

Ghabry commented Aug 25, 2020

4 years and 5 months. One of the longest standing issues 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants