-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embric of Wulfhammer's Castle: Sound effect repeating incorrectly [MIDI loop point] #834
Comments
Is the midi loop set with a "111" MIDI event controller change? Event details: The event time corresponds to the loop start place when the song ends. RTP's Battle3.mid example: 98 00 (delta time PPQ, place to restart) B0 6F 00 (controller 111) |
Yep. |
Added an isolated test case and emscripten link in the OP post. |
Moving to 0.6.3 because of massive Midi work right now :). This is partially fixed now (FmMidi only). |
The AudioDecoder will destroy it because it is stuck at "IsFinished" but the BGM must be kept alive to match RPG_RT. Fix EasyRPG#834
The AudioDecoder will destroy it because it is stuck at "IsFinished" but the BGM must be kept alive to match RPG_RT. Fix EasyRPG#834
The AudioDecoder will destroy it because it is stuck at "IsFinished" but the BGM must be kept alive to match RPG_RT. Fix EasyRPG#834
The AudioDecoder will destroy it because it is stuck at "IsFinished" but the BGM must be kept alive to match RPG_RT. Fix EasyRPG#834
The AudioDecoder will destroy it because it is stuck at "IsFinished" but the BGM must be kept alive to match RPG_RT. Fix EasyRPG#834
4 years and 5 months. One of the longest standing issues 🎉 |
This game has a scene in which the Duchess goes to sleep. It is accompanied by a short sound effect, which in RPG_RT plays only once. In EasyRPG, however, the sound effect incorrectly constantly repeats itself.
To reproduce, load the save game and talk to Alice (immediately in front of the Duchess in the savegame)
Edit: added MIDI loop test case and online test in Emscripten (with FMMIDI).
See #2199
The text was updated successfully, but these errors were encountered: