New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeuterisGrey: heroine makes double steps #872

Closed
carstene1ns opened this Issue Apr 24, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@carstene1ns
Member

carstene1ns commented Apr 24, 2016

game download, emscripten

This game uses some common event to check for collisions etc. and has a sideview jump-n-run like feeling to it. However, the heroine seems to always run/makes double steps:
shot

Savegame to skip the intro: Save01.zip

@Zegeri

This comment has been minimized.

Show comment
Hide comment
@Zegeri

Zegeri May 1, 2016

Member

Here's a brief explanation: This is caused by the way we handle Game_Character::remaining_step. In DynRPG, this same field is called movementFramesLeft. This field goes from 256 to 0 during any movement.
In RPG_RT, right after a move command is executed, its remaining_step is reduced within the same frame. While in Player, it's first reduced in the next frame. For that frame, PeuterisGrey scripts think the hero isn't moving and causes the double step.

Member

Zegeri commented May 1, 2016

Here's a brief explanation: This is caused by the way we handle Game_Character::remaining_step. In DynRPG, this same field is called movementFramesLeft. This field goes from 256 to 0 during any movement.
In RPG_RT, right after a move command is executed, its remaining_step is reduced within the same frame. While in Player, it's first reduced in the next frame. For that frame, PeuterisGrey scripts think the hero isn't moving and causes the double step.

@Zegeri

This comment has been minimized.

Show comment
Hide comment
@Zegeri

Zegeri May 2, 2016

Member

5886cc8 fixes the double steps, but it doesn't fix the weird scrolling.

Member

Zegeri commented May 2, 2016

5886cc8 fixes the double steps, but it doesn't fix the weird scrolling.

@Zegeri

This comment has been minimized.

Show comment
Hide comment
@Zegeri

Zegeri Jul 14, 2016

Member

This can be closed. @scurest fixed this with b3026d2.

Member

Zegeri commented Jul 14, 2016

This can be closed. @scurest fixed this with b3026d2.

@fdelapena fdelapena added this to the 0.4.2 milestone Jul 14, 2016

@scurest scurest referenced this issue Jul 14, 2016

Merged

Fix #703, #884 #913

@fdelapena fdelapena closed this Jul 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment