Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
RFC: How to handle Ineluki's MP3 patch #939
Back in the days when RPG Maker 2000 did not support mp3 music natively, there was a patch by Ineluki that used a modified
While we could certainly do a string comparison to check for them (like #731) and display a warning, this will lead to a problem: Even if the mp3 file is copied over to the music folder retaining the wav filename, the
A thing that came to mind is just stripping off the
Edit: btw. Calm Falls (#940) uses this patch.
I think the easiest solution is to really parse the files when it ends on ".link" but this needs some adjustments to the read filename to make it FileFinder-friendly.
I would suggest to only read the first line and to ignore the rest.
..\ -> Strip this part, we are in Music
Maybe the filefinder should do the path normalising???
added a commit
Jul 28, 2016
I would like to propose a patch for this:
There are also other commits in this branch because it is based on my Audio branch because I needed a way to pass paths directly to the audiointerface instead of depending on them calling FindMusic.