Embric of Wulfhammer's Castle: Designer Room background changes incorrectly #961

Closed
Siltala opened this Issue Jul 27, 2016 · 7 comments

Comments

Projects
None yet
3 participants
@Siltala

Siltala commented Jul 27, 2016

In one specific room in this game there's a bug causing the room background to change suddenly upon movement to/from a certain area.

As usual, this video explains it better: https://www.heavylobster.com/files/another_bug.mp4

(also tested in RPG_RT, the background doesn't magically change there.)

How to reproduce this bug should be quite clear from the video.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jul 27, 2016

Member

This looks a bit like #761.

Member

carstene1ns commented Jul 27, 2016

This looks a bit like #761.

@Siltala

This comment has been minimized.

Show comment
Hide comment
@Siltala

Siltala Jul 27, 2016

Oh, it does actually look very similar. Sorry, must have missed that one.

Siltala commented Jul 27, 2016

Oh, it does actually look very similar. Sorry, must have missed that one.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jul 27, 2016

Member

Actually, while trying to fix the issue mentioned above, I found out this is another issue after all...
We do not have a looping map here. Reopening.

map_props

Member

carstene1ns commented Jul 27, 2016

Actually, while trying to fix the issue mentioned above, I found out this is another issue after all...
We do not have a looping map here. Reopening.

map_props

@carstene1ns carstene1ns reopened this Jul 30, 2016

@carstene1ns carstene1ns added Window/Scenes and removed Duplicate labels Jul 30, 2016

@carstene1ns carstene1ns added this to the 0.5.0 milestone Jul 30, 2016

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jul 30, 2016

Member

This could be a simple off-by-one error, because this seems to fix it:

diff --git a/src/game_map.cpp b/src/game_map.cpp
index aca22d8..800c282 100644
--- a/src/game_map.cpp
+++ b/src/game_map.cpp
@@ -386,7 +386,7 @@ void Game_Map::ScrollRight(int distance) {
                                parallax_x -= distance / 2;
                }
        } else {
-               if (map_info.position_x + distance <= (GetWidth() - 20) * SCREEN_TILE_WIDTH) {
+               if (map_info.position_x + distance < (GetWidth() - 20) * SCREEN_TILE_WIDTH) {
                        map_info.position_x += distance;
                        if (map_info.parallax_horz)
                                parallax_x -= distance / 2;

However, we still have jumping glitches, when the background is smaller than the map.

Member

carstene1ns commented Jul 30, 2016

This could be a simple off-by-one error, because this seems to fix it:

diff --git a/src/game_map.cpp b/src/game_map.cpp
index aca22d8..800c282 100644
--- a/src/game_map.cpp
+++ b/src/game_map.cpp
@@ -386,7 +386,7 @@ void Game_Map::ScrollRight(int distance) {
                                parallax_x -= distance / 2;
                }
        } else {
-               if (map_info.position_x + distance <= (GetWidth() - 20) * SCREEN_TILE_WIDTH) {
+               if (map_info.position_x + distance < (GetWidth() - 20) * SCREEN_TILE_WIDTH) {
                        map_info.position_x += distance;
                        if (map_info.parallax_horz)
                                parallax_x -= distance / 2;

However, we still have jumping glitches, when the background is smaller than the map.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Sep 8, 2016

Member

I am not sure, if I should add this shortly before release...
Do we know any other game with a parallax background, that does not have loping maps?

Member

carstene1ns commented Sep 8, 2016

I am not sure, if I should add this shortly before release...
Do we know any other game with a parallax background, that does not have loping maps?

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Sep 8, 2016

Member

There is a parallax background test in TestGame-2000 and I didn't observe this problem there.
Neither in Ara Fell.

Member

Ghabry commented Sep 8, 2016

There is a parallax background test in TestGame-2000 and I didn't observe this problem there.
Neither in Ara Fell.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Sep 9, 2016

Member

I created a 0.5.1 milestone for release in ~2 months. You can move this there if you want. Will do the same for my nobihaza 1 issue because I cant fix it completely :(

Member

Ghabry commented Sep 9, 2016

I created a 0.5.1 milestone for release in ~2 months. You can move this there if you want. Will do the same for my nobihaza 1 issue because I cant fix it completely :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment