New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Mouse/Touch support #1057

Merged
merged 2 commits into from Mar 7, 2017

Conversation

Projects
None yet
4 participants
@carstene1ns
Member

carstene1ns commented Oct 9, 2016

The touch part is not tested, as I do not have such device.
(Maybe @fdelapena tries this out with his iPhone 馃樇)

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 9, 2016

Member

As said in the other PR no time, so only one thing:
Afaik @Zegeri had some touch movement code for the map, maybe would be a worth to add his code (not online yet?) to allow MV-like navigation :D

Member

Ghabry commented Oct 9, 2016

As said in the other PR no time, so only one thing:
Afaik @Zegeri had some touch movement code for the map, maybe would be a worth to add his code (not online yet?) to allow MV-like navigation :D

@Zegeri

This comment has been minimized.

Show comment
Hide comment
@Zegeri

Zegeri Oct 12, 2016

Member

Afaik @Zegeri had some touch movement code for the map, maybe would be a worth to add his code (not online yet?) to allow MV-like navigation :D

Not worth it for now, my code had some issues with Touch Hero/Collision With Hero triggers and didn't work in looping maps. Also I deleted that branch by accident 炉\_(銉)_/炉.

Member

Zegeri commented Oct 12, 2016

Afaik @Zegeri had some touch movement code for the map, maybe would be a worth to add his code (not online yet?) to allow MV-like navigation :D

Not worth it for now, my code had some issues with Touch Hero/Collision With Hero triggers and didn't work in looping maps. Also I deleted that branch by accident 炉\_(銉)_/炉.

@Ghabry

Ghabry approved these changes Oct 13, 2016

@Ghabry

Ghabry approved these changes Oct 13, 2016

Looks good to me. Works on Windows with fingers, pen is ignored (SDL problem?).
Only problem is that 2 finger is sometimes detected as 1 when you don't place them at the same moment but works as expected.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Oct 16, 2016

Member

I think this should stay open for test under iOS (needs some toolchain work before), will try to add swipe up/down left/right and will disable mouse for now (maybe add some --enable-mouse parameter) so we can make sure the touch input is recognized and not due some bug is using mouse instead (this may be platform/driver dependent, at least is disabled by a check, but no idea if it works).

Member

carstene1ns commented Oct 16, 2016

I think this should stay open for test under iOS (needs some toolchain work before), will try to add swipe up/down left/right and will disable mouse for now (maybe add some --enable-mouse parameter) so we can make sure the touch input is recognized and not due some bug is using mouse instead (this may be platform/driver dependent, at least is disabled by a check, but no idea if it works).

@fdelapena

fdelapena approved these changes Nov 11, 2016 edited

Tap and two-finger tap works as expected on real iOS based hardware 馃憤

@carstene1ns carstene1ns added this to the 0.6.0 milestone Mar 3, 2017

carstene1ns added some commits Oct 7, 2016

Enable basic mouse button/wheel support (#634)
- left button => decision
- right button => cancel
- wheel can be used in list selectables
Mouse support is disabled by default, add a CLI option to enable
Add minimal touch support for decision/cancel
Related: #634
This is a very naive implementation, as it only checks whether fingers
touch the screen and not where they touch and in which direction swipes
are done or if there are gestures, etc.
Touch input is disabled by default, add a CLI option to enable
@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Mar 5, 2017

Member

This one could be merged for now, as the additional features are guarded by CLI options (and can be toggled on the fly by scene_options later).

Member

carstene1ns commented Mar 5, 2017

This one could be merged for now, as the additional features are guarded by CLI options (and can be toggled on the fly by scene_options later).

@Ghabry Ghabry modified the milestones: 0.5.1, 0.6.0 Mar 6, 2017

@Ghabry Ghabry merged commit 5436e96 into EasyRPG:master Mar 7, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns deleted the carstene1ns:mouse_touch branch Mar 17, 2017

Ghabry added a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment