Battle 2k3: Implement "Enable Combo", skill reflection, (de)buff and minor things #1069

Merged
merged 15 commits into from Jan 8, 2017

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Oct 29, 2016

Enable combo simply repeats the whole action and reduces a counter.

Skill reflect is a bit more "fun" but was surprisingly easy to implement in the BattleAlgorithm (good API design): GetTarget lies to the caller and returns the source when reflected. Therefore battleAlgorithm will handle the whole damage calc and applycation automatically correct.
The only exception is PlayAnimation because the animation is played twice: Once normal and once on the reflected target.

(De)buffing is that [x] Reduce Resistance option. When checked this buffs or debuffs the Attack Elements by 1/-1. Maximum shift is +-1 and when e.g. an actor is buffed with +1 and the enemy debuffs it becomes 0.

Related: #821

Bonus:
2k3: Damage numbers "jump" now
Multitarget attacks did not target all actors when one was dead
"Attack party" flag for weapons
Preemptive attack for 2k

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 31, 2016

Member

Here some bad video (somehow offset is wrong): https://gfycat.com/ObviousBogusIberianchiffchaff

Uses "3x combo" and Poison causes reflect. As you can see the first poison attack is not reflected but then the enemy gets poison and the next 2 are reflected.
Afterwards Ice is used which is reflected 3 times.
RPG_RT is left

Member

Ghabry commented Oct 31, 2016

Here some bad video (somehow offset is wrong): https://gfycat.com/ObviousBogusIberianchiffchaff

Uses "3x combo" and Poison causes reflect. As you can see the first poison attack is not reflected but then the enemy gets poison and the next 2 are reflected.
Afterwards Ice is used which is reflected 3 times.
RPG_RT is left

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 31, 2016

Member

And looks like our damage calculation is still wrong

Member

Ghabry commented Oct 31, 2016

And looks like our damage calculation is still wrong

@Ghabry Ghabry changed the title from Battle 2k3: Implement "Enable Combo" and skill reflection to Battle 2k3: Implement "Enable Combo", skill reflection and (de)buff Nov 1, 2016

@Ghabry Ghabry changed the title from Battle 2k3: Implement "Enable Combo", skill reflection and (de)buff to Battle 2k3: Implement "Enable Combo", skill reflection, (de)buff and minor things Nov 2, 2016

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Nov 2, 2016

Member

Done. Will not add "Attack twice with weapon" and "Two weapon attack" in this PR because this needs a bigger BattleAlgorithm change...

Merge warning: When #1050 merged don't merge this until I fixed the GetEquipment calls! (Same for #1069 before #1050)

Member

Ghabry commented Nov 2, 2016

Done. Will not add "Attack twice with weapon" and "Two weapon attack" in this PR because this needs a bigger BattleAlgorithm change...

Merge warning: When #1050 merged don't merge this until I fixed the GetEquipment calls! (Same for #1069 before #1050)

@fdelapena fdelapena added this to the 0.5.1 milestone Nov 14, 2016

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jan 7, 2017

Member

Right, have to update GetEquipment. Thank you past self

Member

Ghabry commented Jan 7, 2017

Right, have to update GetEquipment. Thank you past self

@fdelapena fdelapena removed the Needs Rebase label Jan 7, 2017

@carstene1ns carstene1ns merged commit 3eaf29c into EasyRPG:master Jan 8, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:battle branch May 28, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request #1069 from Ghabry/battle
Battle 2k3: Implement "Enable Combo", skill reflection, (de)buff and minor things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment