New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Game Browser: Add XYZ image support #1074

Merged
merged 2 commits into from Nov 10, 2016

Conversation

Projects
None yet
4 participants
@Ghabry
Member

Ghabry commented Nov 1, 2016

If you wonder why a new lib: Because I don't want to load SDL while in the gamebrowser.
The XYZ is converted to PNG (without file-io writes in a buffer) and this is returned to Java and processed by the normal Android Image API.

Before:
screenshot_2016-11-01-17-52-58

After:
screenshot_2016-11-01-17-50-10

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Nov 1, 2016

Member

For reference: To create a stub header invoke in "app/src/main/java":

javah -cp . org.easyrpg.player.java.file

Where "java.file" points to the Java file (without .java ending) that contains the native method.

Member

Ghabry commented Nov 1, 2016

For reference: To create a stub header invoke in "app/src/main/java":

javah -cp . org.easyrpg.player.java.file

Where "java.file" points to the Java file (without .java ending) that contains the native method.

@fdelapena

This comment has been minimized.

Show comment
Hide comment
@fdelapena

fdelapena Nov 1, 2016

Contributor

LGTM, despite it duplicates the code, keeps the JNI code separated, though maybe could be ifdef'd somehow and use some function overload or whatever, not sure if the point was to keep the code pollution free this way.

Contributor

fdelapena commented Nov 1, 2016

LGTM, despite it duplicates the code, keeps the JNI code separated, though maybe could be ifdef'd somehow and use some function overload or whatever, not sure if the point was to keep the code pollution free this way.

Android: Add guard around the gamebrowser library to prevent game bro…
…wser crashes when the lib failed to load.
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Nov 2, 2016

Member

Added a guard to allow loading of the GameBrowser even if library loading fails for devs that forget to run ndk-build. @BlisterB approves this :P

Member

Ghabry commented Nov 2, 2016

Added a guard to allow loading of the GameBrowser even if library loading fails for devs that forget to run ndk-build. @BlisterB approves this :P

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Nov 2, 2016

Member

Hahahaha, I finally used to take the .so files from the .apk. Really quicker !

It's good to see all of your nice PRs ! I'm sorry to not be really active, I don't have the motivation to code out of work (maybe Dark Souls 3 is a part of the explanation). I hope I will have the motivation to rework input layout in the next months :).

Member

BlisterB commented Nov 2, 2016

Hahahaha, I finally used to take the .so files from the .apk. Really quicker !

It's good to see all of your nice PRs ! I'm sorry to not be really active, I don't have the motivation to code out of work (maybe Dark Souls 3 is a part of the explanation). I hope I will have the motivation to rework input layout in the next months :).

@carstene1ns carstene1ns merged commit 8dc40d6 into EasyRPG:master Nov 10, 2016

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:android-gamebrowser-xyz branch Jan 24, 2017

@Ghabry Ghabry added this to the 0.5.1 milestone Feb 22, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request #1074 from Ghabry/android-gamebrowser-xyz
Android Game Browser: Add XYZ image support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment