New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lack of transparency after rotating #1077

Merged
merged 1 commit into from Nov 14, 2016

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Nov 14, 2016

This is a regression introduced with the performance optimisations for bitmap blits.
In this case getting rid of the fast path doesn't hurt much because is only taken when a rotation happens.

Related: #898

Fix lack of transparency after rotating when the original image lacke…
…d transparency.

This is a regression introduced with the performance optimisations for bitmap blits.
In this case getting rid of the fast path doesn't hurt much because is only taken when a rotation happens.

Related: #898
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Nov 14, 2016

Member

Test case: Save06.lsd.zip

Go next to the steam thing and press "1" multiple times. When no UFOs appear reenter and repeat. When they become stationary you will see that there is no black border anymore

screenshot_0
screenshot_1

Member

Ghabry commented Nov 14, 2016

Test case: Save06.lsd.zip

Go next to the steam thing and press "1" multiple times. When no UFOs appear reenter and repeat. When they become stationary you will see that there is no black border anymore

screenshot_0
screenshot_1

@carstene1ns carstene1ns merged commit 8bf38ca into EasyRPG:master Nov 14, 2016

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:issue-898 branch Jan 24, 2017

@Ghabry Ghabry added this to the 0.5.1 milestone Feb 22, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request #1077 from Ghabry/issue-898
Fix lack of transparency after rotating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment