New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overclocked GPU/BUS,added shaders,disabled vsync. #1078

Merged
merged 2 commits into from Feb 10, 2017

Conversation

Projects
None yet
4 participants
@Rinnegatamante
Member

Rinnegatamante commented Nov 16, 2016

This pull will do four different things:

  • Adds filters (aka shaders) support (at the moment there are 4 shaders available: None, Sharp Bilinear, LCD 3x, xBR). These will be interchangeable during player execution by the user by swinging the touchscreen left/right.

  • Increases GPU, GPU crossbar and BUS clocks (from 111 mhz to 222 mhz) allowing shaders to get the best results.

  • Disables vsync. This will produce a slight frameboost without any bad conseguence.

  • Fix some typo errors and updates Makefile for new vitasdk compatibility.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 8, 2017

Member

You messed up the rebase, needs a squash.

Member

Ghabry commented Feb 8, 2017

You messed up the rebase, needs a squash.

Show outdated Hide outdated src/psp2_ui.h
};
extern vita2d_shader* shaders[];
extern char* shader_names[];

This comment has been minimized.

@Ghabry

Ghabry Feb 8, 2017

Member

Why are you declaring the shaders as extern? Are they used anywhere outside of psp2_ui.cpp?

@Ghabry

Ghabry Feb 8, 2017

Member

Why are you declaring the shaders as extern? Are they used anywhere outside of psp2_ui.cpp?

"Sharp Bilinear",
"LCD 3x",
"xBR"
};

This comment has been minimized.

@Ghabry

Ghabry Feb 8, 2017

Member

If the reason for extern are strange linker errors: Declare these variables as "static"

@Ghabry

Ghabry Feb 8, 2017

Member

If the reason for extern are strange linker errors: Declare these variables as "static"

Overclocked GPU/BUS,added shaders,disabled vsync.
Overclocked GPU/BUS,added shaders,disabled vsync.
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 9, 2017

Member

Just noticed that the Makefile lacks a check if TOOLCHAIN_DIR is defined, but isn't your fault.

Member

Ghabry commented Feb 9, 2017

Just noticed that the Makefile lacks a check if TOOLCHAIN_DIR is defined, but isn't your fault.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 10, 2017

Member

I get linker errors.
Please move the global variables above class Psp2Ui from psp2_ui.h into an anonymous namespace (namespace {}) in the .cpp file. Fixes it for me.

And -lpthread is missing

Member

Ghabry commented Feb 10, 2017

I get linker errors.
Please move the global variables above class Psp2Ui from psp2_ui.h into an anonymous namespace (namespace {}) in the .cpp file. Fixes it for me.

And -lpthread is missing

PSVITA: Moved rendering code to a separated thread.
PSVITA: Moved rendering code to a separated thread.
@Ghabry

Ghabry approved these changes Feb 10, 2017

Vita PR builder: Success

@Ghabry Ghabry merged commit e3d0ba4 into EasyRPG:master Feb 10, 2017

5 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 12, 2017

Member

A user on gbatemp reported that this made (even with shaders disabled) some games, e.g. Ara Fell, significantly slower. Theres no obvious reason why. Could be related to how the upstream-version handles audio, lets wait for the new audio code to be finished.

Member

Ghabry commented Feb 12, 2017

A user on gbatemp reported that this made (even with shaders disabled) some games, e.g. Ara Fell, significantly slower. Theres no obvious reason why. Could be related to how the upstream-version handles audio, lets wait for the new audio code to be finished.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 16, 2017

Member

@Rinnegatamante
A user reports a massive slowdown (15 FPS) in "Ara Fell" since the gpu-code changes, even in my "sdl_con_audio_sin_mixer" branch. Maybe scheduling or new vitasdk problem.

Ara Fell Demo Download:
http://queenscourt.org/othergames.php

Member

Ghabry commented Feb 16, 2017

@Rinnegatamante
A user reports a massive slowdown (15 FPS) in "Ara Fell" since the gpu-code changes, even in my "sdl_con_audio_sin_mixer" branch. Maybe scheduling or new vitasdk problem.

Ara Fell Demo Download:
http://queenscourt.org/othergames.php

@Rinnegatamante

This comment has been minimized.

Show comment
Hide comment
@Rinnegatamante

Rinnegatamante Feb 21, 2017

Member

I doubt it's an issue related to vitasdk, maybe it could be related to the new gpu rendering thread + lots of sounds thread working.

Member

Rinnegatamante commented Feb 21, 2017

I doubt it's an issue related to vitasdk, maybe it could be related to the new gpu rendering thread + lots of sounds thread working.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 21, 2017

Member

We confirmed already that even with the new audio code it runs bad, but havn't tested rolling back to the non-render-thread version yet.

Member

Ghabry commented Feb 21, 2017

We confirmed already that even with the new audio code it runs bad, but havn't tested rolling back to the non-render-thread version yet.

@Ghabry Ghabry added this to the 0.5.1 milestone Feb 22, 2017

@carstene1ns carstene1ns added the PSVita label May 7, 2017

Ghabry added a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request #1078 from Rinnegatamante/shaders
Overclocked GPU/BUS,added shaders,disabled vsync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment