Fix lcf-size calculation for non-ascii-strings in event commands #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdelapena
approved these changes
Jan 24, 2017
carstene1ns
approved these changes
Jan 25, 2017
Ghabry
pushed a commit
to libretro/easyrpg-libretro
that referenced
this pull request
May 22, 2018
Fix lcf-size calculation for non-ascii-strings in event commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes RPG_RT more happy when loading our savegames
(Stream read error)
To reproduce use a "Speicherstein" in Vampires Dawn and save in EasyRPG.
Load in RPG_RT: Old version: Stream read error. New version: Loads fine.
I'm quite sure
int RawStruct<RPG::EventCommand>::LcfSizein liblcf has the same bug because reencoding with lcf2xml results in "Stream read error" again.