New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lcf-size calculation for non-ascii-strings in event commands #1090

Merged
merged 1 commit into from Jan 25, 2017

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Jan 24, 2017

This makes RPG_RT more happy when loading our savegames
(Stream read error)

To reproduce use a "Speicherstein" in Vampires Dawn and save in EasyRPG.
Load in RPG_RT: Old version: Stream read error. New version: Loads fine.

I'm quite sure int RawStruct<RPG::EventCommand>::LcfSize in liblcf has the same bug because reencoding with lcf2xml results in "Stream read error" again.

@carstene1ns carstene1ns merged commit 921a708 into EasyRPG:master Jan 25, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry added this to the 0.5.1 milestone Feb 22, 2017

@Ghabry Ghabry deleted the Ghabry:save_corruption_fix branch May 28, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request #1090 from Ghabry/save_corruption_fix
Fix lcf-size calculation for non-ascii-strings in event commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment