Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make RNG portable #1104
The intention of this PR is to make random number generation totally portable by:
Imo all random number changes look correct, just have 2 other small things.
I'm not sure if
That line was definitely wrong. Just nobody ever noticed it, because the function is unused - our Auto Battle code currently ignores Skills.
Good to see GetRandomNumber/ChanceOf everywhere now to improve the randomness because our old code has a non-even randomness-distribution because most of the code only uses the incorrect rand() % number code :/.