New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix game breaking bugs in "The Huntress of the Hollow" and "ThisEvent" savegame loading issue #1131

Merged
merged 5 commits into from Mar 27, 2017

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Mar 22, 2017

See issues #1127 and #1129
Additionally this fixes the tutorial. Bug in "CHange Class" command (thx @carstene1ns)

Fixed the Event 10005 is invalid problem after loading a savegame. See https://community.easyrpg.org/t/some-little-player-bugs/352/8

Also removed some unused battle functions (just some cleanup)

@Ghabry Ghabry changed the title from Fix game breaking bugs in "The Huntress of the Hollow" to Fix game breaking bugs in "The Huntress of the Hollow" and "ThisEvent" savegame loading issue Mar 22, 2017

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Mar 23, 2017

Member

Did you test the "CommandChangeClass" change? I must admit, I only cared for HOTH, which uses case 2 (learn additionally).

Member

carstene1ns commented Mar 23, 2017

Did you test the "CommandChangeClass" change? I must admit, I only cared for HOTH, which uses case 2 (learn additionally).

@carstene1ns carstene1ns self-assigned this Mar 23, 2017

@carstene1ns carstene1ns added this to the 0.5.1 milestone Mar 23, 2017

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Mar 23, 2017

Member

No havnt't tested case 1 yet, assumed you did it yes :D. will do

Member

Ghabry commented Mar 23, 2017

No havnt't tested case 1 yet, assumed you did it yes :D. will do

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Mar 26, 2017

Member

I have revoked the proposed patch (it worked partly though).
This does mostly the same and addionally fixes other things: carstene1ns@c0344bc.
Would be nice if you could rebase to remove the old commit.

Member

carstene1ns commented Mar 26, 2017

I have revoked the proposed patch (it worked partly though).
This does mostly the same and addionally fixes other things: carstene1ns@c0344bc.
Would be nice if you could rebase to remove the old commit.

Ghabry and others added some commits Mar 22, 2017

Use the event_ids stored in the savegame when setting up the interpre…
…ters during load.

This fixes references to ThisEvent after savegame loading.
(Message: ID 10005 is invalid)
Fix skills + message in Event command "Change Class" Related #759 Fix…
… the skill options "Learn additionally" and "Learn based on level" This fixes the tutorial in "The Huntress of the Hollow", the skill "Scout" was deleted before. Additionally this makes the "level up"/"skill learned" message box behaviour similiar to RPG_RT.
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Mar 27, 2017

Member

Thanks for the patch, applied

Member

Ghabry commented Mar 27, 2017

Thanks for the patch, applied

@carstene1ns carstene1ns merged commit a86a303 into EasyRPG:master Mar 27, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request #1131 from Ghabry/huntress-of-hollow
Fix game breaking bugs in "The Huntress of the Hollow" and "ThisEvent" savegame loading issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment