Refactor and fix for parallax BGs #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor parallax handling into a dedicated namespace in Game_Map. Treats SaveMapInfo::parallax_* info as an override and uses the RPG::Map parallax fields as fallback when they are empty. This fixes #1071.
ie. using the values from GetParallaxParams. Also, Game_Map now interacts with the parallax variables only through the function is Game_Map::Parallax.
carstene1ns
approved these changes
Apr 1, 2017
Ghabry
approved these changes
Apr 1, 2017
|
Thanks for the code cleanup and the docs |
Ghabry
added a commit
to libretro/easyrpg-libretro
that referenced
this pull request
May 22, 2018
Refactor and fix for parallax BGs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
parallax_*values in the SaveMapInfo object are currently treated as "the current value of the parallax parameteres", but in RPG_RT they seem to be treated as an override, and the values in the map properties should be used if they aren't set. This PR implements this, which fixes #1071.There's also a general refactor of the parallax handling into one namespace, more docs, and readability improvements for
Scroll{Left,Right,Up,Down}.