New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTP stuff #1139

Merged
merged 4 commits into from Apr 4, 2017

Conversation

Projects
None yet
3 participants
@carstene1ns
Member

carstene1ns commented Apr 3, 2017

  • Add support for our RTP
  • Supports multiple RTPs to be set from environment
  • Adds official English 2k RTP names

@carstene1ns carstene1ns added this to the 0.5.1 milestone Apr 3, 2017

Show outdated Hide outdated src/filefinder.cpp
// Windows paths are split by semicolon, Unix paths by colon
std::function<bool(char32_t)> f = [](char32_t t) {
return t == ';' || t == ':';

This comment has been minimized.

@Ghabry

Ghabry Apr 3, 2017

Member

This must be if-defed because Splitting at ":" will damage the path on Windows due to the drive letters being C:\

@Ghabry

Ghabry Apr 3, 2017

Member

This must be if-defed because Splitting at ":" will damage the path on Windows due to the drive letters being C:\

@Ghabry

Besides that minor doc thing: lgtm

NOTE: All '*_RTP_PATH' variables support directory lists, using colon (':') or
semicolon (';') as separator. Useful when you have multiple translated RTP
versions or directories with extra files.

This comment has been minimized.

@Ghabry

Ghabry Apr 4, 2017

Member

Remove "or semicolon(';')" because no manpage support unter Windows

@Ghabry

Ghabry Apr 4, 2017

Member

Remove "or semicolon(';')" because no manpage support unter Windows

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Apr 4, 2017

Member

Our manual page is not really limited by the platform, everthing documented there should work under Windows as well. We could even ship a html version with the player.exe (see also #747).

Member

carstene1ns commented Apr 4, 2017

Our manual page is not really limited by the platform, everthing documented there should work under Windows as well. We could even ship a html version with the player.exe (see also #747).

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Apr 4, 2017

Member

Jenkins: Test this please
Makes sense, I revoke my review.

Member

Ghabry commented Apr 4, 2017

Jenkins: Test this please
Makes sense, I revoke my review.

@Ghabry

Ghabry approved these changes Apr 4, 2017

@Ghabry Ghabry merged commit 43568fa into EasyRPG:master Apr 4, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns deleted the carstene1ns:rtps branch Apr 4, 2017

Ghabry added a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment