New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in horizontal scrolling introduced in 7f83a3bf #1148

Merged
merged 1 commit into from Apr 22, 2017

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Apr 22, 2017

http://devopsreactions.tumblr.com/post/74372071314/the-code-refactoring-trap

Related #1147 (Note that the misalignment of the background on game start is not fixed by this - even exists in 0.5. What is fixed is the map after the tent-dialog-cutscene)

This also fixes the bugreport by Undertale and Earthbound lover in "Continue Stop Rise" (report was: some doors entrances are now in walls instand of the door)

@Ghabry Ghabry added this to the 0.5.2 milestone Apr 22, 2017

@@ -1432,7 +1432,7 @@ void Game_Map::Parallax::Scroll(int distance_right, int distance_down) {
parallax_x -=
std::min(
distance_right,
distance_right * (parallax_width - SCREEN_TARGET_HEIGHT) / (GetWidth() - 20) / (SCREEN_TILE_WIDTH / TILE_SIZE)
distance_right * (parallax_width - SCREEN_TARGET_WIDTH) / (GetWidth() - 20) / (SCREEN_TILE_WIDTH / TILE_SIZE)

This comment has been minimized.

@carstene1ns

carstene1ns Apr 22, 2017

Member

Upps.

@carstene1ns

@carstene1ns carstene1ns merged commit b8e3902 into EasyRPG:master Apr 22, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
@scurest

This comment has been minimized.

Show comment
Hide comment
@scurest

scurest Apr 22, 2017

Contributor

My bad ;;

Contributor

scurest commented Apr 22, 2017

My bad ;;

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request #1148 from Ghabry/development
Fix regression in horizontal scrolling introduced in 7f83a3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment