New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed useless delay thread call in renderer thd. #1158

Merged
merged 1 commit into from May 7, 2017

Conversation

Projects
None yet
3 participants
@Rinnegatamante
Member

Rinnegatamante commented May 4, 2017

Such call is completely useless since rescheduling is already performed with sceKernelWaitSema calls and produces unnecessary slowdowns in the renderer thread.

@carstene1ns

No way to test this.
Possibility of race conditions should be ok, because of the semaphores.
Not a big fan of tight loops, but the kernel should do proper delaying.

@Ghabry

Ghabry approved these changes May 7, 2017

@carstene1ns carstene1ns merged commit 5ec6974 into EasyRPG:master May 7, 2017

5 checks passed

GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns added this to the 0.5.2 milestone May 7, 2017

@carstene1ns carstene1ns added the PSVita label May 7, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request #1158 from Rinnegatamante/patch-1
Removed useless delay thread call in renderer thd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment