New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1165 #1166

Merged
merged 1 commit into from May 21, 2017

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented May 16, 2017

See the commit message for an explanation.

GetTimer returns now the remaining seconds (rounded up) instead of th…
…e frames.

This fixes a bug when code checks for "Timer >= 1s" followed by "Timer <= 0".
Because EasyRPG checked the frames both tests failed for the frames 1-59 (less then 1s, more then 0s).
The value is now rounded up to next second, to match RPG_RT behaviour.

Thix fixes another bug in CommandControlVariable: For Timer reads the variable was set to the frames, not to seconds.

Fix #1165

@fdelapena fdelapena added this to the 0.5.2 milestone May 21, 2017

@carstene1ns

Looks good to me... do we know other games with wrong behaviour because of this timer issue?

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry May 21, 2017

Member

I'm not aware of any. Probably many games that used this still ran due to luck or they used Timer 1 >= 1s and Timer 1 <= 1s as the 2 checks, then you don't have that bug window (the game will run the event 1second too early but will otherwise work.

Member

Ghabry commented May 21, 2017

I'm not aware of any. Probably many games that used this still ran due to luck or they used Timer 1 >= 1s and Timer 1 <= 1s as the 2 checks, then you don't have that bug window (the game will run the event 1second too early but will otherwise work.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns May 21, 2017

Member

At least this fixed some annoying bugs in the "The Sacred Tears TRUE" intro.
Left is current master, right this branch:
video

Member

carstene1ns commented May 21, 2017

At least this fixed some annoying bugs in the "The Sacred Tears TRUE" intro.
Left is current master, right this branch:
video

@carstene1ns carstene1ns merged commit 3a81396 into EasyRPG:master May 21, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:issue-1165 branch May 28, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment