New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebPlayer: fixes unwanted scrolling on Arrowkey press #1188

Merged
merged 2 commits into from May 31, 2017

Conversation

Projects
None yet
3 participants
@rygos
Contributor

rygos commented May 25, 2017

fixes unwanted scrolling on Arrowkey press and spacebar.
For older Chrome Versions and some other browsers this fix disables the browser functions for f1 to f12

Marcel Hering added some commits May 25, 2017

Marcel Hering
Merge pull request #1 from rygos/rygos-arrow-keypatch
fix prevents scrolling on arrow key press
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry May 25, 2017

Member

You somehow generated 2 commits. Use "git rebase -i HEAD~2" to remove the merge commit (delete the lien) and push with -f

Member

Ghabry commented May 25, 2017

You somehow generated 2 commits. Use "git rebase -i HEAD~2" to remove the merge commit (delete the lien) and push with -f

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry May 27, 2017

Member

Jenkins: Test this please

Member

Ghabry commented May 27, 2017

Jenkins: Test this please

@Ghabry

Ghabry approved these changes May 27, 2017

Works flawless in Edge. All F-Keys are filtered (even F5) and no scrolling anymore.

@carstene1ns carstene1ns merged commit 6bb6680 into EasyRPG:master May 31, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns added this to the 0.5.2 milestone Jun 10, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request #1188 from rygos/master
WebPlayer: fixes unwanted scrolling on Arrowkey press
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment