Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebPlayer: fixes unwanted scrolling on Arrowkey press #1188

Merged
merged 2 commits into from May 31, 2017

Conversation

rygos
Copy link
Contributor

@rygos rygos commented May 25, 2017

fixes unwanted scrolling on Arrowkey press and spacebar.
For older Chrome Versions and some other browsers this fix disables the browser functions for f1 to f12

@Ghabry
Copy link
Member

Ghabry commented May 25, 2017

You somehow generated 2 commits. Use "git rebase -i HEAD~2" to remove the merge commit (delete the lien) and push with -f

@Ghabry
Copy link
Member

Ghabry commented May 27, 2017

Jenkins: Test this please

Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawless in Edge. All F-Keys are filtered (even F5) and no scrolling anymore.

@carstene1ns carstene1ns merged commit 6bb6680 into EasyRPG:master May 31, 2017
@carstene1ns carstene1ns added this to the 0.5.2 milestone Jun 10, 2017
Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018
WebPlayer: fixes unwanted scrolling on Arrowkey press
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants