New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "を" and "ヲ" with "ヴ" in the "Enter Hero name" scene #1193

Merged
merged 1 commit into from May 31, 2017

Conversation

Projects
None yet
3 participants
@kakurasan
Contributor

kakurasan commented May 30, 2017

On Windows (+ RPG_RT) there is not "を" or "ヲ" in the "Enter Hero name" scene and there is "ヴ" instead.

Hiragana:
RPG_RT on Windows (hiragana)
Katakana:
RPG_RT on Windows (katakana)

EasyRPG Player (unpatched)
EasyRPG Player (unpatched)

This patch replaces "を" and "ヲ" with "ヴ", and allows users to input "ヴ".

EasyRPG Player (patched)
EasyRPG Player (patched)

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry May 30, 2017

Member

Besides being consistent with RPG_RT:
Imo one of the two "wo" can be kept because why should be ヴ displayed twice.

Which one is more useful in names: を or ヲ? Pick one :D

Member

Ghabry commented May 30, 2017

Besides being consistent with RPG_RT:
Imo one of the two "wo" can be kept because why should be ヴ displayed twice.

Which one is more useful in names: を or ヲ? Pick one :D

@kakurasan

This comment has been minimized.

Show comment
Hide comment
@kakurasan

kakurasan May 30, 2017

Contributor

In general, both "を" and "ヲ" are rarely used for names in Japan and I guess that's why RPG_RT users can't input "を" or "ヲ".

Which one is more useful in names: を or ヲ? Pick one :D

The only difference is hiragana or katakana. I think almost all Japanese users (including me) don't need "を" or "ヲ".

Contributor

kakurasan commented May 30, 2017

In general, both "を" and "ヲ" are rarely used for names in Japan and I guess that's why RPG_RT users can't input "を" or "ヲ".

Which one is more useful in names: を or ヲ? Pick one :D

The only difference is hiragana or katakana. I think almost all Japanese users (including me) don't need "を" or "ヲ".

@Ghabry

Ghabry approved these changes May 30, 2017

@carstene1ns carstene1ns merged commit 3079be6 into EasyRPG:master May 31, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@kakurasan kakurasan deleted the kakurasan:hero_name_vu branch Jun 2, 2017

@carstene1ns carstene1ns added this to the 0.5.2 milestone Jun 10, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request #1193 from kakurasan/hero_name_vu
Replace "を" and "ヲ" with "ヴ" in the "Enter Hero name" scene
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment