New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Output system #1199

Merged
merged 10 commits into from Jun 23, 2017

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Jun 7, 2017

console-0 5 2

^----- Proposed screenshot for the blogpost

New features:

  • The message overlay can now collect all messages since startup (Graphics::Init was moved to the beginning of Player::Init) and shows them when the Ui is ready (e.g. the NDSP error message on the 3DS)
  • For file-log and on-screen similiar messages increment now a counter [x10] which is appended to the line. For the file-log a message is always written twice: The 1st time it happens and a 2nd time how often it was duplicated (this is to ensure that something is logged in case of crashes), (see screenshot)
  • The FileFinder got a new function to strip path components outside of the game path (see screenshot, look at the filenames reported). When the path is outside the game path it does nothing, so RTP paths are not touched.
  • Instead of hardcoding "\n" in the messages I use the linebreak function of @rohkea , simplified the code a bit (see screenshot)

Bugfixes:

  • The timeout of the console lines was coupled to the framerate, the timeout is now correctly handled in Update()
  • The linebreak function did not break the last word when the last word exceeded the limit

@fdelapena fdelapena added this to the 0.5.2 milestone Jun 7, 2017

@carstene1ns

Looks good to me.
Can you please remove the annoying picpointer messages while you are at it?
And rebasing would be nice, too... ;-)

Ghabry added some commits Jun 6, 2017

Make Output of BGM/SE Warnings messages more readable by stripping th…
…e path component that is not in the game directory.

Also add some linebreaks to give more space for longer filenames.
Output: Buffer similiar messages before writing them to file.
The first time the message is always written (to be sure to have at least one debug line before a crash) and then the same message is repeated with a counter.
Remove remaining usages of \n in Output::Warning.
Not changed for Output::Error because this uses a different code path to render on the screen.

@Ghabry Ghabry removed the Needs Rebase label Jun 17, 2017

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jun 17, 2017

Member

Rebased. But havnt cleaned up message spam yet.

Member

Ghabry commented Jun 17, 2017

Rebased. But havnt cleaned up message spam yet.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jun 17, 2017

Member

Great! Maybe removing all output of PicPointer messages is not a good idea, if this regresses later. So having at least one message indicating the patch is used would be fine.

Member

carstene1ns commented Jun 17, 2017

Great! Maybe removing all output of PicPointer messages is not a good idea, if this regresses later. So having at least one message indicating the patch is used would be fine.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Jun 23, 2017

Member

Merging this... We can further reduce message spam (i.e. picpointer) later.

Member

carstene1ns commented Jun 23, 2017

Merging this... We can further reduce message spam (i.e. picpointer) later.

@carstene1ns carstene1ns merged commit e7c906e into EasyRPG:master Jun 23, 2017

5 of 6 checks passed

OSX Job building
Details
Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:output branch Sep 24, 2017

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment