New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EHR & Desolate city cutscene (issue 1226) #1232

Merged
merged 2 commits into from Jul 31, 2017

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Jul 30, 2017

See commit message

Tested with: Nobihazard 2, Material Game and DirectionTest (see #1020)

Don't apply a direction change when a new event page is executed when…
… the old page and new page direction are the same.

Fix #1226

The patch provided in #1020 was incorrect because it used the current character direction instead of the new page direction.
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 30, 2017

Member

Can anybody test if this fixes Desolate City?

Member

Ghabry commented Jul 30, 2017

Can anybody test if this fixes Desolate City?

@Ghabry Ghabry changed the title from Fix EHR cutscene (issue 1226) to Fix EHR & Desolate city cutscene (issue 1226) Jul 30, 2017

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 30, 2017

Member

Added fix for Desolate City

Member

Ghabry commented Jul 30, 2017

Added fix for Desolate City

Refresh the Map directly when a move command toggled a switch.
This fixes a incorrect looking direction when the move route changed the direction and the switch invokes a new page.

Before the new page direction applied, now the move route direction applies.
Fixes a broken church cutscene in Desolate City - The Bloody Dawn.
@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Jul 31, 2017

Member

#1198 could be related but is not fixed

Member

Ghabry commented Jul 31, 2017

#1198 could be related but is not fixed

@carstene1ns carstene1ns merged commit 60cf686 into EasyRPG:master Jul 31, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns added this to the 0.5.3 milestone Jul 31, 2017

@Ghabry Ghabry deleted the Ghabry:issue-1226 branch Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment