New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simplified Chinese support in hero name input #1239

Merged
merged 3 commits into from Aug 15, 2017

Conversation

Projects
None yet
3 participants
@fdelapena
Contributor

fdelapena commented Aug 8, 2017

Based on a table used in a forum fork.

~~~~Untested yet. Please review ;)~~~~

Show outdated Hide outdated src/cache.cpp Outdated
{"", "", "", "", "", "", "", "西", "", ""},
{"", "", "", "", "", "", "", "", "", ""},
{"", "", "", "", "", "", Window_Keyboard::TO_ZH_CN_1, "", Window_Keyboard::DONE_ZH_CN}
},

This comment has been minimized.

@Ghabry

Ghabry Aug 8, 2017

Member

I wonder how the "alphabet" for chinese is picked. Probably phonetic?

@Ghabry

Ghabry Aug 8, 2017

Member

I wonder how the "alphabet" for chinese is picked. Probably phonetic?

@Ghabry

Ghabry approved these changes Aug 14, 2017

@carstene1ns

carstene1ns approved these changes Aug 15, 2017 edited

I would like to have some FIXME: comment for the Backdrop height, but otherwise LGTM.

@carstene1ns carstene1ns merged commit cbfa4cb into EasyRPG:master Aug 15, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@fdelapena fdelapena deleted the fdelapena:simp_chinese_nameinput branch Aug 15, 2017

@carstene1ns carstene1ns added this to the 0.5.3 milestone Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment