New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ThisEvent in CommonEvents #1265

Merged
merged 2 commits into from Sep 20, 2017

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Sep 19, 2017

Works across all engines - EraseEvent is handled in a special way to prevent regressions.

I decided to make these commits independend of my RPG2k3 1.12 PR because this makes the reviewing easier and doesn't depend on any new liblcf chunks.

Fix #1201

Ghabry added some commits Sep 19, 2017

Forward the callers event ID to common event calls. A special handlin…
…g for EraseEvent which prevents erasing from CommonEvents when the engine is not RPG2k3E prevents bugs.

@Ghabry Ghabry added the Refactor label Sep 19, 2017

@Ghabry Ghabry added this to the 0.5.3 milestone Sep 19, 2017

@carstene1ns carstene1ns merged commit 923f7f9 into EasyRPG:master Sep 20, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:this-event branch Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment