New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin Rpg2k3 1.12 support #1273

Merged
merged 10 commits into from Oct 22, 2017

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Oct 6, 2017

This implements many RPG2k3 1.12 picture features:

  • Spritesheets
  • Z layer
  • Picture ID, opacity & co. through variable
  • Name substitution (as known from PPP)
  • Survive map change

Not part of this PR:

  • Battle pictures
  • Affected by Tone/Shake/Flash

Test cases: EasyRPG/TestGame#36

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Oct 6, 2017

Member

jenkins: test this please 😘

Member

carstene1ns commented Oct 6, 2017

jenkins: test this please 😘

@Ghabry Ghabry added this to the 0.5.3 milestone Oct 9, 2017

@carstene1ns

Looks good to me. However, no way to test this.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 12, 2017

Member

Besides the TestGame-2000 map I only know one "game" that uses it. I will try to get this Testgame by Archeia that is shipped with RPG2k3 1.12a.

ArcheiaPictureTutorial.zip

Member

Ghabry commented Oct 12, 2017

Besides the TestGame-2000 map I only know one "game" that uses it. I will try to get this Testgame by Archeia that is shipped with RPG2k3 1.12a.

ArcheiaPictureTutorial.zip

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 12, 2017

Member

I found two bugs in the testgame when using Player: THe "Animated picture" option shows the full image for one frame.
WHen leaving the basement the magic circle suddenly appears again after the fadeout. Though not sure if this is just one of our many bugs with transitions.

Member

Ghabry commented Oct 12, 2017

I found two bugs in the testgame when using Player: THe "Animated picture" option shows the full image for one frame.
WHen leaving the basement the magic circle suddenly appears again after the fadeout. Though not sure if this is just one of our many bugs with transitions.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 13, 2017

Member

Fixed by moving "data.frames = data.frames + 1;" after the if-block. Rest remains unchanged.
Ready from my side.

Member

Ghabry commented Oct 13, 2017

Fixed by moving "data.frames = data.frames + 1;" after the if-block. Rest remains unchanged.
Ready from my side.

Show outdated Hide outdated src/game_picture.cpp Outdated
@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Oct 22, 2017

Member

This branch is broken when there are pictures and you use fast-forward. They stay, seems like erase_on_map_change needs to be set somewhere or maybe Game_Screen::Reset() needs true?

Member

carstene1ns commented Oct 22, 2017

This branch is broken when there are pictures and you use fast-forward. They stay, seems like erase_on_map_change needs to be set somewhere or maybe Game_Screen::Reset() needs true?

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 22, 2017

Member

hu? How can fast-forward affect this. Will check.

Member

Ghabry commented Oct 22, 2017

hu? How can fast-forward affect this. Will check.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Oct 22, 2017

Member

forget "fast forward", was a flawed test.

Member

carstene1ns commented Oct 22, 2017

forget "fast forward", was a flawed test.

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Oct 22, 2017

Member

Works now, thanks!

Member

carstene1ns commented Oct 22, 2017

Works now, thanks!

@carstene1ns carstene1ns merged commit 27cb97d into EasyRPG:master Oct 22, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:rpg2k3_1.12 branch Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment