New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Russian name input #1278

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
4 participants
@rohkea
Member

rohkea commented Oct 9, 2017

Not very elegant (RuLatn and Letter are almost identical), but useful for many games.

screenshot_0

Can also be used for the following languages with no known games: Belarusian, Bulgarian, Crimean Tatar, Ukrainian (although those will feel second-class citizens as the extra letters are below Russian and not in their alphabetic places).

NOT useful for Serbian and Macedonian (too many extra letters). There are no known games in Serbian and Macedonian, but we’d eventually need to devise an encoding-independent way of specifying a language for such things. (Also needed for UTF-8 support.)

Add Russian name input
Can also be used for the following languages with no known games: Belarusian, Bulgarian, Crimean Tatar, Ukrainian (although those will feel second-class citizens as the extra letters are below Russian and not in their alphabetic places).

NOT useful for Serbian and Macedonian (too many extra letters). There are no known games in Serbian and Macedonian anyway.

@carstene1ns carstene1ns added the UX label Oct 9, 2017

@carstene1ns carstene1ns added this to the 0.5.3 milestone Oct 9, 2017

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 9, 2017

Member

When fdela refactored the name scene for his Hacktober T-Shirt the duplicate letter array should be gone ;)

Member

Ghabry commented Oct 9, 2017

When fdela refactored the name scene for his Hacktober T-Shirt the duplicate letter array should be gone ;)

@Ghabry

Ghabry approved these changes Oct 9, 2017

@Ghabry Ghabry merged commit 1f58a83 into EasyRPG:master Oct 9, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@rohkea rohkea deleted the rohkea:add_cyrillic_name_input branch Oct 10, 2017

@rohkea

This comment has been minimized.

Show comment
Hide comment
@rohkea

rohkea Oct 10, 2017

Member

OK, I forgot the letter Ш ^^' Will add in another PR this evening

Member

rohkea commented Oct 10, 2017

OK, I forgot the letter Ш ^^' Will add in another PR this evening

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 10, 2017

Member

Hm, I even reviewed the alphabet if its complete ^^', missed it too

Member

Ghabry commented Oct 10, 2017

Hm, I even reviewed the alphabet if its complete ^^', missed it too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment