New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes (#1268, #1198, two undocumented GetActors uses, Bitmap::Create(w, h, col). Split from other PR) #1288

Merged
merged 4 commits into from Oct 29, 2017

Conversation

Projects
None yet
3 participants
@20kdc
Contributor

20kdc commented Oct 18, 2017

This includes a fix for #1268, a fix for #1198, and adds support for two undocumented(?) GetActors uses.
This was split from #1287, so the testcase for this (which proves said GetActors calls exist) is there.

The future suggestion-aka-nitpick referring to this part is:
"IsStopping in Player ought to be something like IsReadyToMove?"

@20kdc 20kdc changed the title from Various fixes (#1268, #1198, two undocumented GetActors uses. Split from other PR) to Various fixes (#1268, #1198, two undocumented GetActors uses, Bitmap::Create(w, h, col). Split from other PR) Oct 18, 2017

@Ghabry Ghabry added this to the 0.5.4 milestone Oct 18, 2017

@Ghabry

This comment has been minimized.

Member

Ghabry commented Oct 18, 2017

68fe9c3 becomes easier to review by removing the whitespace and an interesting find. @CherryDT this could be exported via the Editor GUI ^^.

Looks good to me. Because we still have some time until 0.5.4 this PR is a good oportunity to talk about renaming IsMoving and IsStopping as 20kdc already proposed. Just thinking about good names :)

@carstene1ns

This comment has been minimized.

Member

carstene1ns commented Oct 19, 2017

Jenkins: ok to test

btw. Jenkins spam disabled successfully 🥇

@@ -673,6 +673,13 @@ bool Game_Player::GetOffVehicle() {
return true;
}
bool Game_Player::IsStopping() const {
// Issue #1268 (player moving too early on a moveroute when using airship) was because MoveRoutes use this.

This comment has been minimized.

@Ghabry

Ghabry Oct 29, 2017

Member

How about "// Prevent MoveRoute execution while the airship is ascending"

This comment has been minimized.

@20kdc

20kdc Oct 29, 2017

Contributor

nods Will add that now.

@Ghabry

This comment has been minimized.

Member

Ghabry commented Oct 29, 2017

Jenkins: Test this please

@Ghabry

Ghabry approved these changes Oct 29, 2017

@20kdc

This comment has been minimized.

Contributor

20kdc commented Oct 29, 2017

Whoops, forgot to rebase to latest while dealing with the comment. Will do that now.

20kdc added some commits Oct 13, 2017

Minor nitpick fix : Bitmap::Create(w, h, col) alpha support
Confusion with this caused the Yume 2kki black squares bug, so might as well fix it.
Might as well squash it.
Thanks to Ghabry and carstene1ns for... helping with spotting usages of the function!
Fix #1268 w/ IsStopping override in Game_Player [M]
It might be an idea to rename IsStopping to something like IsMovable, and IsMovable to IsControlMovable?

([M]: With changed comment)
Hopefully fix #1198 by removing original_pattern
original_pattern isn't actually RPG_RT behavior, apparently - the issue 1198 shows this.

I made a testcase, but not much of one.
 I had hoped to check different ways of setting the pattern,
 but apparently walking and page changes are the only things that do it.

So, test this with stuff before considering applying.
Thanks to Ghabry for basically doing most of the work.
The technical description given plus a look through the code showed original_pattern wasn't being honoured, and now I know why.
Support for GetActors() parameters in ChangeClass and ChangeBattleCom…
…mands

Yup, that thing I suspected was there, actually turned out to be there in testing!
I am going to definitely need to ship you my testcase with the PR for this, I can tell.

@carstene1ns carstene1ns merged commit e35a5ea into EasyRPG:master Oct 29, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment