New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement even more obscure SetVehicleLocation behaviour #1303

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Oct 30, 2017

SetVehicleLocation actually supports changing the map without doing a transition (not as thought in #1257) while the party is boarded but only when the target map has an event with the same event ID.

Because this sounds more like a bug than intended behaviour this was implemented using a normal teleport and without a check if the target map has a valid event. Doesn't match the RPG_RT behaviour due to the transition but this bug is strange and only used by a few VIPRPG games, not worth implementing perfectly.

The patch is good enough to fix the test case. I hope not even worse offenders appear. I reordered the code a bit so it matches other teleport code. Moved the vehicle reposition code after the "return false" in the if-block to ensure that the vehicle isn't moved before a teleport can start.

Test case: http://velvel.net/Cynthia/List/Search/%E5%91%AA%E3%81%84%E3%81%AE%E3%81%93%E3%81%86%E3%82%82%E3%82%8A%E3%81%95%E3%82%93/true/1

@Ghabry Ghabry added this to the 0.5.4 milestone Oct 30, 2017

SetVehicleLocation actually supports changing the map without doing a…
… transition while the party is boarded but only when the target map has an event with the same event ID.

Because this sounds more like a bug than intended behaviour this was implemented using a normal teleport and without a check if the target map has a valid event. Doesn't match the RPG_RT behaviour due to the transition but this bug is strange and only used by a few VIPRPG games, not worth implementing perfectly.
@carstene1ns

RPG_RT madness again.
This is one edge case that hopefully does not break something else...

@Ghabry

This comment has been minimized.

Member

Ghabry commented Oct 30, 2017

Hopefully not because the "teleport" case I added usually crashes the engine :D.

@carstene1ns

This comment has been minimized.

Member

carstene1ns commented Oct 30, 2017

allrighty then.

@carstene1ns carstene1ns merged commit 314f1ca into EasyRPG:master Oct 31, 2017

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:vehicle branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment