New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split SDL UIs for further development #1327

Merged
merged 1 commit into from Jan 28, 2018

Conversation

Projects
None yet
3 participants
@carstene1ns
Member

carstene1ns commented Jan 18, 2018

Basic testing of both done (both under Linux, not Wii).

The SDL1.2 UI has been slimmed down a bit:

  • No mouse support
  • No OpenAL audio support

The SDL2 UI has less platform specific stuff (only Emscripten).

@carstene1ns carstene1ns added this to the 0.5.4 milestone Jan 18, 2018

@Ghabry

This comment has been minimized.

Member

Ghabry commented Jan 24, 2018

Nice refactor to make removing SDL1 easier someday.

I directly diffed the 2 cpp and 2 h files with each other. SDL1 still contains GEKKO code (y) and SDL2 finally no ugly RequestVideoMode code (y).

CMake build works.

Needs GEKKO test when the newlib-PR is merged.

@Ghabry

Ghabry approved these changes Jan 24, 2018

@Ghabry

This comment has been minimized.

Member

Ghabry commented Jan 24, 2018

applied my newlib PR on your PR. Works fine in Dolphin

@Ghabry Ghabry merged commit 30e4cd3 into EasyRPG:master Jan 28, 2018

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GCW0 Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns deleted the carstene1ns:sdlsplit branch Jan 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment