New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle 2k: Always allow escape escaping from random encounters #1350

Merged
merged 1 commit into from Apr 28, 2018

Conversation

Projects
None yet
2 participants
@Ghabry
Member

Ghabry commented Apr 28, 2018

Finally something simple to review ;)

Due to an oversight GetAllowEscape was used to check if random encouter escapes are allowed but this flag is only for escape spells, Escaping is always possible in random encouters >.>

Iirc this was reported via mail as a bug in Vampires Dawn, but can't find it anymore.

@Ghabry Ghabry added the Battle label Apr 28, 2018

@Ghabry Ghabry added this to the 0.5.4 milestone Apr 28, 2018

@carstene1ns

This comment has been minimized.

Member

carstene1ns commented Apr 28, 2018

Also mentioned on gbatemp.

@Ghabry

This comment has been minimized.

Member

Ghabry commented Apr 28, 2018

Thanks! Then this was not via mail but via gbatemp.

@carstene1ns

Good find! 👍

The "escape_allowed" flag in GameSystem is only used for escape skill…
…s, not for random encounter escapes.

For random encounters fleeing is always allowed in RPG2k.

@carstene1ns carstene1ns merged commit 1285fea into EasyRPG:master Apr 28, 2018

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GCW0 Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:battle-escape branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment