New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window handling changes (zoom + fullscreen) #1406

Merged
merged 3 commits into from Sep 17, 2018

Conversation

Projects
None yet
3 participants
@carstene1ns
Member

carstene1ns commented Jul 25, 2018

No description provided.

@Ghabry

This comment has been minimized.

Member

Ghabry commented Aug 1, 2018

Only tested SDL2 which works fine.
Did you make any SDL1 tests? Can this slowdown Wii build (by accidently enabling zoom for it again)

@carstene1ns

This comment has been minimized.

Member

carstene1ns commented Aug 1, 2018

I have tested sdl1 under linux only. However, should not affect Wii at all.

@Ghabry

This comment has been minimized.

Member

Ghabry commented Aug 1, 2018

Under Windows there is now a minor artifact on startup:
For a second it shows a fullscreen black window with a white 640x480 window in the middle, after that second it renders the Logo Scene in fullscreen.
Will see if this can be improved.

@Ghabry

This comment has been minimized.

Member

Ghabry commented Aug 1, 2018

Untested but because this is likely an artifact due to a non redrawn Window it could be probably fixed via

if (fullscreen) {
ToggleFullscreen();
UpdateDisplay();
}

in the startup code

@Ghabry

This comment has been minimized.

Member

Ghabry commented Aug 13, 2018

Adding "RenderClear & RenderPresent" before SetLogicalRenderSize reduces a visual glitch on Windows. Otherwise is fine for me.

Fixes the MacOSX problem.

@Ghabry Ghabry merged commit c0bcf7b into EasyRPG:master Sep 17, 2018

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GCW0 Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@carstene1ns carstene1ns deleted the carstene1ns:window-handling branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment