Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obey Map and Database save_count when loading games #1441

Merged
merged 2 commits into from Oct 29, 2018

Conversation

Projects
None yet
4 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Oct 13, 2018

Resolves: #1203

I tested this by creating a new project in Steam RM2k.

A map event with this code:

Text: before save
OpenSaveMenu
Text: After Save

Another map event which walks around randomly.

And a parallel common event with this code:

Text: Start
Loop
  Wait 4.0 seconds
EndLoop

This also correctly writes the database_save_count to the LSD file. Before it looks like it was never written to save games.

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:save_count branch 3 times, most recently from a3c5f30 to 73a918e Oct 13, 2018

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

fmatthew5876 commented Oct 13, 2018

Added support for Map Chunk 0x5A.

I tested this with the following scenarios:

  • rm2k steam game
  • rm2k3 steam game converted from rm2k steam
  • rm2k3 steam game converted from rm2k steam where the map was converted (saved) but the ldb was not. In this case the map is 2k3 but the ldb is still 2k. rm2k3 doesn't reset the event states when it should and neither does player.

Now this depends on: EasyRPG/liblcf#263

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:save_count branch from a29bd9b to 825b18f Oct 14, 2018

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:save_count branch 2 times, most recently from 2354a01 to 8951bab Oct 16, 2018

Show resolved Hide resolved src/game_map.cpp Outdated

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:save_count branch from 8951bab to fcb3844 Oct 27, 2018

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:save_count branch from fcb3844 to efdb870 Oct 27, 2018

@Ghabry Ghabry merged commit fdf169a into EasyRPG:master Oct 29, 2018

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GCW0 Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.