Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.4 regression fixes #1477

Merged
merged 6 commits into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@Ghabry
Copy link
Member

Ghabry commented Nov 4, 2018

Fixes all known regressions in 0.5.4 for now plus the crash in OSX when enumerating a non-readable directory.

(The Android fix is not tested, abusing the PR builder to get a APK)

@Ghabry Ghabry added this to the 0.5.5 (or 0.6.0) -> we will see milestone Nov 4, 2018

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Nov 4, 2018

the "intent.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);" fix doesn't work :/

@Ghabry Ghabry force-pushed the Ghabry:0.5.4-regression-fix branch from 5978c6b to 6448844 Nov 4, 2018

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Nov 4, 2018

Added another commit which removes intermediate files from Android, Idea/Android Studio will recreate them when importing the folder as Gradle project.

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Nov 4, 2018

The lazy workaround works for me, can open K9 Mail with the files attached.
Please do tests on your devices @fdelapena @carstene1ns

(Works on LineageOS Android 7.1.2)

@fdelapena
Copy link
Contributor

fdelapena left a comment

Rport works in Android 6.0.1 as expected.

@fdelapena fdelapena added the Crash label Nov 5, 2018

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Nov 6, 2018

jenkins: test this please (need an APK for testing^^')

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Nov 8, 2018

The bug report option does work again on my samsung tablet. 👍, but before merging let's push a fix for newlib based ports here and afterwards replace the google play apk.

@carstene1ns carstene1ns force-pushed the Ghabry:0.5.4-regression-fix branch from 6448844 to 926a1b1 Nov 8, 2018

@carstene1ns carstene1ns merged commit 199ae6f into EasyRPG:master Nov 8, 2018

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@Ghabry Ghabry deleted the Ghabry:0.5.4-regression-fix branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.