Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for AddState() #1489

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
5 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Nov 7, 2018

When a state is added, all states with priority <= max_priority - 10
should be cleared.

Fix for AddState()
When a state is added, all states with priority <= max_priority - 10
should be cleared.
@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

fmatthew5876 commented Nov 7, 2018

@CherryDT

How about state recovery in battle? We just check states[i] >= Data::states[i].hold_turn and then roll the auto_release probability each turn until its healed.

Is that correct?

What happens if you add a state whose priority is below the threshold due to some other state you already have? Is it immediately cleared?

@CherryDT

This comment has been minimized.

Copy link

CherryDT commented Nov 7, 2018

State recovery: Yes, it's correct (assuming you do the per-turn increase of the counter before checking. otherwise you'd need >).

Immediately cleared: Yes.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Nov 8, 2018

What should be also checked is if states that are induced in battle but autocleared because of this behaviour are still reported in the 2k battle msg.
But out of scope here.

@Ghabry Ghabry merged commit bcfdad1 into EasyRPG:master Nov 8, 2018

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:status branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.