Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor Game_Character classes 1 of 2 #1502
Depends on: EasyRPG/liblcf#282
This PR refactors the
The goals are:
Unless I find more issues to fix, I think this PR is nearly done. It's a lot of commits, so once the liblcf dependencies are in it could be broken up if needed.
Here are some save chunks I'm still unsure about:
referenced this pull request
Nov 19, 2018
My observation is that
Is that assumption correct?
I'm requesting a split after the commit "Remove Game_Vehicle::driving" with the commit "Add compatibility hack for old Player save games" cherry-picked. (using commit msg instead of hashes here, less chaotic)
Additional 3 commits also cherry-pickable imo from more down the commit log (if possible conflict free):
Only stuff I found: "Encapsulte" in one commit message.
Which brings this PR to 19 commits + 1 pick + 3 optional picks