Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Scene_Status stats with HP #1512

Merged
merged 2 commits into from Dec 2, 2018

Conversation

Projects
None yet
4 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Nov 30, 2018

Fixes one of the bugs in #1443

@Ghabry
Copy link
Member

Ghabry left a comment

Because this was the only purpose of "bool draw_actorname = false" for Window_EquipStatus I ask you to completely remove this codepath from Window_EquipStatus (and always take the true-codepath). Don't forget to remove the doc-comment.

@Ghabry Ghabry added this to the 0.6.0 (likely) milestone Dec 1, 2018

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

fmatthew5876 commented Dec 1, 2018

Removed the actor name logic

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 1, 2018

the whole window renders as ATK for me btw

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:window_fix branch from d68ce25 to 979601c Dec 1, 2018

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

fmatthew5876 commented Dec 1, 2018

the whole window renders as ATK for me btw

Ouch.. Refactor gone wrong.. Fixed now. Thanks for checking.

@Ghabry

Ghabry approved these changes Dec 2, 2018

@Ghabry Ghabry merged commit 9ad99ec into EasyRPG:master Dec 2, 2018

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:window_fix branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.